From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
Bob Copeland <me@bobcopeland.com>, Bing Zhao <bzhao@marvell.com>,
Lennert Buytenhek <buytenh@wantstofly.org>,
Ivo van Doorn <IvDoorn@gmail.com>,
Gertjan van Wingerde <gwingerde@gmail.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
Luciano Coelho <coelho@ti.com>
Subject: Re: [PATCH 3.5] cfg80211: enforce lack of interface combinations
Date: Thu, 15 Mar 2012 14:53:05 +0530 [thread overview]
Message-ID: <20120315092304.GA13932@vasanth-laptop> (raw)
In-Reply-To: <1331802709.3432.4.camel@jlt3.sipsolutions.net>
On Thu, Mar 15, 2012 at 10:11:49AM +0100, Johannes Berg wrote:
> On Thu, 2012-03-15 at 14:32 +0530, Vasanthakumar Thiagarajan wrote:
> > On Thu, Mar 15, 2012 at 09:58:27AM +0100, Johannes Berg wrote:
> > > On Thu, 2012-03-15 at 14:27 +0530, Vasanthakumar Thiagarajan wrote:
> > > > On Thu, Mar 15, 2012 at 09:51:28AM +0100, Johannes Berg wrote:
> > > > > On Thu, 2012-03-15 at 14:12 +0530, Vasanthakumar Thiagarajan wrote:
> > > > > > On Tue, Mar 13, 2012 at 04:06:03PM +0100, Johannes Berg wrote:
> > > > > > > From: Johannes Berg <johannes.berg@intel.com>
> > > > > > >
> > > > > > > My grand plan to allow drivers to gradually move over
> > > > > > > to advertising virtual interface combinations and only
> > > > > > > enforce with drivers that do want it enforced doesn't
> > > > > > > seem to be working out, only Christian ever added the
> > > > > > > advertising (to carl9170), nobody else did.
> > > > > > >
> > > > > > > Begin enforcing combinations in cfg80211 so that users
> > > > > > > can rely on the information reported about a device.
> > > > > >
> > > > > > This breaks ath6kl AP mode and P2P, is it expected that the driver
> > > > > > needs to register the combination (?) even it supports a single
> > > > > > interface?
> > > > >
> > > > > Kalle tells me that ath6kl does support multiple virtual interfaces, but
> > > > > if it didn't then it wouldn't have to register combinations.
> > > > >
> > > > > I suspect you're using
> > > > > driver_param=use_p2p_group_interface=1
> > > > > in wpa_supplicant?
> > > >
> > > > Actually, I verified only AP mode, since it affects any sort of change interface,
> > > > I mentioned P2P as well. AP is expected to work without any issue right?.
> > >
> > > As long as you don't try to add the AP interface as the second one...
> >
> > Right, I'm trying on a single interface.
>
> Hmm, ok, looking at the code again it seems there's a bug ... let me try
> to fix it.
V2 fixes this, thanks!.
Vasanth
next prev parent reply other threads:[~2012-03-15 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 15:06 [PATCH 3.5] cfg80211: enforce lack of interface combinations Johannes Berg
2012-03-15 8:42 ` Vasanthakumar Thiagarajan
2012-03-15 8:51 ` Johannes Berg
2012-03-15 8:57 ` Vasanthakumar Thiagarajan
2012-03-15 8:58 ` Johannes Berg
2012-03-15 9:02 ` Vasanthakumar Thiagarajan
2012-03-15 9:11 ` Johannes Berg
2012-03-15 9:23 ` Vasanthakumar Thiagarajan [this message]
2012-03-15 9:16 ` [PATCH 3.5 v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315092304.GA13932@vasanth-laptop \
--to=vthiagar@qca.qualcomm.com \
--cc=IvDoorn@gmail.com \
--cc=buytenh@wantstofly.org \
--cc=bzhao@marvell.com \
--cc=coelho@ti.com \
--cc=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=senthilb@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).