From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rndis_wlan: don't report station signal
Date: Thu, 15 Mar 2012 11:58:02 -0400 [thread overview]
Message-ID: <20120315155802.GE31717@tuxdriver.com> (raw)
In-Reply-To: <1331825203.3432.25.camel@jlt3.sipsolutions.net>
On Thu, Mar 15, 2012 at 04:26:43PM +0100, Johannes Berg wrote:
> On Thu, 2012-03-15 at 11:03 -0400, John W. Linville wrote:
> > On Thu, Mar 15, 2012 at 03:47:14PM +0100, Johannes Berg wrote:
> > > On Thu, 2012-03-15 at 10:25 -0400, John W. Linville wrote:
> > > > On Thu, Mar 15, 2012 at 03:13:25PM +0100, Johannes Berg wrote:
> > > > > From: Johannes Berg <johannes.berg@intel.com>
> > > > >
> > > > > The station signal value is supposed to be in dBm
> > > > > which the device can't give, so don't report it.
> > > > >
> > > > > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > > >
> > > > Won't this break functionality for users of this device?
> > >
> > > I don't know if it breaks functionality, but filling in values in the
> > > wrong units doesn't seem like a good plan.
> >
> > No, but if it isn't actually hurting anyting then I would rather
> > change a comment or two (and perhaps augment the nl80211 code) than
> > to simply break things for users.
> >
> > FWIW, cfg80211_wireless_stats has been able to cope with the
> > unspecified units since it was implemented in commit 8990646d.
> > Maybe that was a bug but it is a user-visible one that has been around
> > for years now...
>
> Interesting, I had no idea. I was more concerned with the actual nl80211
> exporting (nl80211_send_station), not wext. Seems like something like
> this patch would be sufficient then:
> http://p.sipsolutions.net/ca88e4afc69683ca.txt
>
> Of course, we could add nl80211 attributes for unspec in the station
> info too.
Yes, I came-up with something similar -- patch to follow...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-03-15 16:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 14:13 [PATCH] rndis_wlan: don't report station signal Johannes Berg
2012-03-15 14:25 ` John W. Linville
2012-03-15 14:47 ` Johannes Berg
2012-03-15 15:03 ` John W. Linville
2012-03-15 15:26 ` Johannes Berg
2012-03-15 15:58 ` John W. Linville [this message]
2012-03-15 15:58 ` [PATCH] cfg80211: allow CFG80211_SIGNAL_TYPE_UNSPEC in station_info John W. Linville
2012-03-15 16:19 ` Cristian Morales Vega
2012-03-15 16:26 ` Larry Finger
2012-03-15 16:33 ` Johannes Berg
2012-03-15 17:25 ` [PATCH v2] " John W. Linville
2012-03-15 17:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315155802.GE31717@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).