* [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
@ 2012-03-26 0:02 Paul Gortmaker
2012-03-26 0:13 ` Julian Calaby
2012-03-26 11:30 ` Hauke Mehrtens
0 siblings, 2 replies; 9+ messages in thread
From: Paul Gortmaker @ 2012-03-26 0:02 UTC (permalink / raw)
To: zajec5; +Cc: linux-wireless, Paul Gortmaker, Hauke Mehrtens, John W. Linville
The following is seen during allmodconfig builds for MIPS:
drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
"bcma: add PCIe host controller"
Add the header instead of implicitly assuming it will be present.
Sounds like a good idea, but that alone doesn't fix anything.
The real problem is that the Kconfig has settings related to whether
PCI is possible, i.e.
config BCMA_HOST_PCI_POSSIBLE
bool
depends on BCMA && PCI = y
default y
config BCMA_HOST_PCI
bool "Support for BCMA on PCI-host bus"
depends on BCMA_HOST_PCI_POSSIBLE
...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
have any dependencies on the above. Add one.
CC: Hauke Mehrtens <hauke@hauke-m.de>
CC: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index c1172da..fb7c80f 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -29,7 +29,7 @@ config BCMA_HOST_PCI
config BCMA_DRIVER_PCI_HOSTMODE
bool "Driver for PCI core working in hostmode"
- depends on BCMA && MIPS
+ depends on BCMA && MIPS && BCMA_HOST_PCI
help
PCI core hostmode operation (external PCI bus).
diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
index 4e20bcf..d2097a1 100644
--- a/drivers/bcma/driver_pci_host.c
+++ b/drivers/bcma/driver_pci_host.c
@@ -10,6 +10,7 @@
*/
#include "bcma_private.h"
+#include <linux/pci.h>
#include <linux/export.h>
#include <linux/bcma/bcma.h>
#include <asm/paccess.h>
--
1.7.9.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
2012-03-26 0:02 [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device Paul Gortmaker
@ 2012-03-26 0:13 ` Julian Calaby
2012-03-26 1:20 ` Paul Gortmaker
2012-03-26 11:30 ` Hauke Mehrtens
1 sibling, 1 reply; 9+ messages in thread
From: Julian Calaby @ 2012-03-26 0:13 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: zajec5, linux-wireless, Hauke Mehrtens, John W. Linville
Hi Paul,
On Mon, Mar 26, 2012 at 11:02, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> The following is seen during allmodconfig builds for MIPS:
>
> drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
> of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
>
> Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
>
> "bcma: add PCIe host controller"
>
> Add the header instead of implicitly assuming it will be present.
> Sounds like a good idea, but that alone doesn't fix anything.
>
> The real problem is that the Kconfig has settings related to whether
> PCI is possible, i.e.
>
> config BCMA_HOST_PCI_POSSIBLE
> bool
> depends on BCMA && PCI = y
> default y
>
> config BCMA_HOST_PCI
> bool "Support for BCMA on PCI-host bus"
> depends on BCMA_HOST_PCI_POSSIBLE
>
> ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
> have any dependencies on the above. Add one.
>
> CC: Hauke Mehrtens <hauke@hauke-m.de>
> CC: John W. Linville <linville@tuxdriver.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
> index c1172da..fb7c80f 100644
> --- a/drivers/bcma/Kconfig
> +++ b/drivers/bcma/Kconfig
> @@ -29,7 +29,7 @@ config BCMA_HOST_PCI
>
> config BCMA_DRIVER_PCI_HOSTMODE
> bool "Driver for PCI core working in hostmode"
> - depends on BCMA && MIPS
> + depends on BCMA && MIPS && BCMA_HOST_PCI
I don't know the hardware, but I'm sure there'd be situations
(probably for embedded devices) where hostmode would be wanted without
the PCI host support - so shouldn't this depend on
BCMA_HOST_PCI_POSSIBLE?
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
2012-03-26 0:13 ` Julian Calaby
@ 2012-03-26 1:20 ` Paul Gortmaker
2012-03-26 1:28 ` Julian Calaby
0 siblings, 1 reply; 9+ messages in thread
From: Paul Gortmaker @ 2012-03-26 1:20 UTC (permalink / raw)
To: Julian Calaby; +Cc: zajec5, linux-wireless, Hauke Mehrtens, John W. Linville
[Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device] On 26/03/2012 (Mon 11:13) Julian Calaby wrote:
> Hi Paul,
>
> On Mon, Mar 26, 2012 at 11:02, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > The following is seen during allmodconfig builds for MIPS:
> >
> > drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
> > of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
> > make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
> >
> > Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
> >
> > "bcma: add PCIe host controller"
> >
> > Add the header instead of implicitly assuming it will be present.
> > Sounds like a good idea, but that alone doesn't fix anything.
> >
> > The real problem is that the Kconfig has settings related to whether
> > PCI is possible, i.e.
> >
> > config BCMA_HOST_PCI_POSSIBLE
> > bool
> > depends on BCMA && PCI = y
> > default y
> >
> > config BCMA_HOST_PCI
> > bool "Support for BCMA on PCI-host bus"
> > depends on BCMA_HOST_PCI_POSSIBLE
> >
> > ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
> > have any dependencies on the above. Add one.
> >
> > CC: Hauke Mehrtens <hauke@hauke-m.de>
> > CC: John W. Linville <linville@tuxdriver.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> >
> > diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
> > index c1172da..fb7c80f 100644
> > --- a/drivers/bcma/Kconfig
> > +++ b/drivers/bcma/Kconfig
> > @@ -29,7 +29,7 @@ config BCMA_HOST_PCI
> >
> > config BCMA_DRIVER_PCI_HOSTMODE
> > bool "Driver for PCI core working in hostmode"
> > - depends on BCMA && MIPS
> > + depends on BCMA && MIPS && BCMA_HOST_PCI
>
> I don't know the hardware, but I'm sure there'd be situations
> (probably for embedded devices) where hostmode would be wanted without
> the PCI host support - so shouldn't this depend on
> BCMA_HOST_PCI_POSSIBLE?
My reading of things is that BCMA_HOST_PCI is equivalent to, or
at most a subset of BCMA_HOST_PCI_POSSIBLE. But if the maintainers
want to tweak things accordingly, then great -- I'm just reporting
what I see in build failures.
Thanks,
Paul.
--
>
> Thanks,
>
> --
> Julian Calaby
>
> Email: julian.calaby@gmail.com
> Profile: http://www.google.com/profiles/julian.calaby/
> .Plan: http://sites.google.com/site/juliancalaby/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
2012-03-26 1:20 ` Paul Gortmaker
@ 2012-03-26 1:28 ` Julian Calaby
2012-03-26 11:34 ` Hauke Mehrtens
0 siblings, 1 reply; 9+ messages in thread
From: Julian Calaby @ 2012-03-26 1:28 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: zajec5, linux-wireless, Hauke Mehrtens, John W. Linville
Hi Paul,
On Mon, Mar 26, 2012 at 12:20, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device] On 26/03/2012 (Mon 11:13) Julian Calaby wrote:
>
>> Hi Paul,
>>
>> On Mon, Mar 26, 2012 at 11:02, Paul Gortmaker
>> <paul.gortmaker@windriver.com> wrote:
>> > The following is seen during allmodconfig builds for MIPS:
>> >
>> > drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
>> > of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
>> > cc1: some warnings being treated as errors
>> > make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
>> >
>> > Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
>> >
>> > "bcma: add PCIe host controller"
>> >
>> > Add the header instead of implicitly assuming it will be present.
>> > Sounds like a good idea, but that alone doesn't fix anything.
>> >
>> > The real problem is that the Kconfig has settings related to whether
>> > PCI is possible, i.e.
>> >
>> > config BCMA_HOST_PCI_POSSIBLE
>> > bool
>> > depends on BCMA && PCI = y
>> > default y
>> >
>> > config BCMA_HOST_PCI
>> > bool "Support for BCMA on PCI-host bus"
>> > depends on BCMA_HOST_PCI_POSSIBLE
>> >
>> > ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
>> > have any dependencies on the above. Add one.
>> >
>> > CC: Hauke Mehrtens <hauke@hauke-m.de>
>> > CC: John W. Linville <linville@tuxdriver.com>
>> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>> >
>> > diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
>> > index c1172da..fb7c80f 100644
>> > --- a/drivers/bcma/Kconfig
>> > +++ b/drivers/bcma/Kconfig
>> > @@ -29,7 +29,7 @@ config BCMA_HOST_PCI
>> >
>> > config BCMA_DRIVER_PCI_HOSTMODE
>> > bool "Driver for PCI core working in hostmode"
>> > - depends on BCMA && MIPS
>> > + depends on BCMA && MIPS && BCMA_HOST_PCI
>>
>> I don't know the hardware, but I'm sure there'd be situations
>> (probably for embedded devices) where hostmode would be wanted without
>> the PCI host support - so shouldn't this depend on
>> BCMA_HOST_PCI_POSSIBLE?
>
> My reading of things is that BCMA_HOST_PCI is equivalent to, or
> at most a subset of BCMA_HOST_PCI_POSSIBLE. But if the maintainers
> want to tweak things accordingly, then great -- I'm just reporting
> what I see in build failures.
That's not the case.
BCMA_HOST_PCI is a separate config option that depends on
...._POSSIBLE but is user selectable. ...._POSSIBLE isn't user
selectable and is automatically "y" when the conditions for PCI
support for BCMA are true.
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
2012-03-26 0:02 [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device Paul Gortmaker
2012-03-26 0:13 ` Julian Calaby
@ 2012-03-26 11:30 ` Hauke Mehrtens
1 sibling, 0 replies; 9+ messages in thread
From: Hauke Mehrtens @ 2012-03-26 11:30 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: zajec5, linux-wireless, John W. Linville
On 03/26/2012 03:02 AM, Paul Gortmaker wrote:
> The following is seen during allmodconfig builds for MIPS:
>
> drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
> of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
>
> Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
>
> "bcma: add PCIe host controller"
>
> Add the header instead of implicitly assuming it will be present.
> Sounds like a good idea, but that alone doesn't fix anything.
>
> The real problem is that the Kconfig has settings related to whether
> PCI is possible, i.e.
>
> config BCMA_HOST_PCI_POSSIBLE
> bool
> depends on BCMA && PCI = y
> default y
>
> config BCMA_HOST_PCI
> bool "Support for BCMA on PCI-host bus"
> depends on BCMA_HOST_PCI_POSSIBLE
>
> ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
> have any dependencies on the above. Add one.
>
> CC: Hauke Mehrtens <hauke@hauke-m.de>
> CC: John W. Linville <linville@tuxdriver.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
>
> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
> index c1172da..fb7c80f 100644
> --- a/drivers/bcma/Kconfig
> +++ b/drivers/bcma/Kconfig
> @@ -29,7 +29,7 @@ config BCMA_HOST_PCI
>
> config BCMA_DRIVER_PCI_HOSTMODE
> bool "Driver for PCI core working in hostmode"
> - depends on BCMA && MIPS
> + depends on BCMA && MIPS && BCMA_HOST_PCI
> help
> PCI core hostmode operation (external PCI bus).
>
> diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
> index 4e20bcf..d2097a1 100644
> --- a/drivers/bcma/driver_pci_host.c
> +++ b/drivers/bcma/driver_pci_host.c
> @@ -10,6 +10,7 @@
> */
>
> #include "bcma_private.h"
> +#include <linux/pci.h>
> #include <linux/export.h>
> #include <linux/bcma/bcma.h>
> #include <asm/paccess.h>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
2012-03-26 1:28 ` Julian Calaby
@ 2012-03-26 11:34 ` Hauke Mehrtens
2012-03-26 18:56 ` Paul Gortmaker
0 siblings, 1 reply; 9+ messages in thread
From: Hauke Mehrtens @ 2012-03-26 11:34 UTC (permalink / raw)
To: Julian Calaby; +Cc: Paul Gortmaker, zajec5, linux-wireless, John W. Linville
On 03/26/2012 04:28 AM, Julian Calaby wrote:
> Hi Paul,
>
> On Mon, Mar 26, 2012 at 12:20, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> [Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device] On 26/03/2012 (Mon 11:13) Julian Calaby wrote:
>>
>>> Hi Paul,
>>>
>>> On Mon, Mar 26, 2012 at 11:02, Paul Gortmaker
>>> <paul.gortmaker@windriver.com> wrote:
>>>> The following is seen during allmodconfig builds for MIPS:
>>>>
>>>> drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
>>>> of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
>>>> cc1: some warnings being treated as errors
>>>> make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
>>>>
>>>> Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
>>>>
>>>> "bcma: add PCIe host controller"
>>>>
>>>> Add the header instead of implicitly assuming it will be present.
>>>> Sounds like a good idea, but that alone doesn't fix anything.
>>>>
>>>> The real problem is that the Kconfig has settings related to whether
>>>> PCI is possible, i.e.
>>>>
>>>> config BCMA_HOST_PCI_POSSIBLE
>>>> bool
>>>> depends on BCMA && PCI = y
>>>> default y
>>>>
>>>> config BCMA_HOST_PCI
>>>> bool "Support for BCMA on PCI-host bus"
>>>> depends on BCMA_HOST_PCI_POSSIBLE
>>>>
>>>> ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
>>>> have any dependencies on the above. Add one.
>>>>
>>>> CC: Hauke Mehrtens <hauke@hauke-m.de>
>>>> CC: John W. Linville <linville@tuxdriver.com>
>>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>>>>
>>>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
>>>> index c1172da..fb7c80f 100644
>>>> --- a/drivers/bcma/Kconfig
>>>> +++ b/drivers/bcma/Kconfig
>>>> @@ -29,7 +29,7 @@ config BCMA_HOST_PCI
>>>>
>>>> config BCMA_DRIVER_PCI_HOSTMODE
>>>> bool "Driver for PCI core working in hostmode"
>>>> - depends on BCMA && MIPS
>>>> + depends on BCMA && MIPS && BCMA_HOST_PCI
>>>
>>> I don't know the hardware, but I'm sure there'd be situations
>>> (probably for embedded devices) where hostmode would be wanted without
>>> the PCI host support - so shouldn't this depend on
>>> BCMA_HOST_PCI_POSSIBLE?
>>
>> My reading of things is that BCMA_HOST_PCI is equivalent to, or
>> at most a subset of BCMA_HOST_PCI_POSSIBLE. But if the maintainers
>> want to tweak things accordingly, then great -- I'm just reporting
>> what I see in build failures.
>
> That's not the case.
>
> BCMA_HOST_PCI is a separate config option that depends on
> ...._POSSIBLE but is user selectable. ...._POSSIBLE isn't user
> selectable and is automatically "y" when the conditions for PCI
> support for BCMA are true.
>
> Thanks,
>
Yes that's correct. BCMA_HOST_PCI_POSSIBLE is used to only show
BCMA_DRIVER_PCI_HOSTMODE if PCI is enabled. For now you are not able to
use PCI host mode without also supporting client mode in bcma. I have
only seen device where an other bcma based device was being behind the
PCIe link.
Hauke
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
2012-03-26 11:34 ` Hauke Mehrtens
@ 2012-03-26 18:56 ` Paul Gortmaker
2012-03-27 10:53 ` Hauke Mehrtens
0 siblings, 1 reply; 9+ messages in thread
From: Paul Gortmaker @ 2012-03-26 18:56 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: Julian Calaby, zajec5, linux-wireless, John W. Linville
The following is seen during allmodconfig builds for MIPS:
drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
"bcma: add PCIe host controller"
Add the header instead of implicitly assuming it will be present.
Sounds like a good idea, but that alone doesn't fix anything.
The real problem is that the Kconfig has settings related to whether
PCI is possible, i.e.
config BCMA_HOST_PCI_POSSIBLE
bool
depends on BCMA && PCI = y
default y
config BCMA_HOST_PCI
bool "Support for BCMA on PCI-host bus"
depends on BCMA_HOST_PCI_POSSIBLE
...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
have any dependencies on the above. Add one.
CC: Hauke Mehrtens <hauke@hauke-m.de>
CC: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[ v2: depend on BCMA_HOST_PCI_POSSIBLE, not BCMA_HOST_PCI ]
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index c1172da..6a0082d 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -29,7 +29,7 @@ config BCMA_HOST_PCI
config BCMA_DRIVER_PCI_HOSTMODE
bool "Driver for PCI core working in hostmode"
- depends on BCMA && MIPS
+ depends on BCMA && MIPS && BCMA_HOST_PCI_POSSIBLE
help
PCI core hostmode operation (external PCI bus).
diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
index 4e20bcf..d2097a1 100644
--- a/drivers/bcma/driver_pci_host.c
+++ b/drivers/bcma/driver_pci_host.c
@@ -10,6 +10,7 @@
*/
#include "bcma_private.h"
+#include <linux/pci.h>
#include <linux/export.h>
#include <linux/bcma/bcma.h>
#include <asm/paccess.h>
--
1.7.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
2012-03-26 18:56 ` Paul Gortmaker
@ 2012-03-27 10:53 ` Hauke Mehrtens
2012-03-27 19:27 ` Paul Gortmaker
0 siblings, 1 reply; 9+ messages in thread
From: Hauke Mehrtens @ 2012-03-27 10:53 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Julian Calaby, zajec5, linux-wireless, John W. Linville
On 03/26/2012 09:56 PM, Paul Gortmaker wrote:
> The following is seen during allmodconfig builds for MIPS:
>
> drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
> of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
>
> Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
>
> "bcma: add PCIe host controller"
>
> Add the header instead of implicitly assuming it will be present.
> Sounds like a good idea, but that alone doesn't fix anything.
>
> The real problem is that the Kconfig has settings related to whether
> PCI is possible, i.e.
>
> config BCMA_HOST_PCI_POSSIBLE
> bool
> depends on BCMA && PCI = y
> default y
>
> config BCMA_HOST_PCI
> bool "Support for BCMA on PCI-host bus"
> depends on BCMA_HOST_PCI_POSSIBLE
>
> ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
> have any dependencies on the above. Add one.
>
> CC: Hauke Mehrtens <hauke@hauke-m.de>
> CC: John W. Linville <linville@tuxdriver.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [ v2: depend on BCMA_HOST_PCI_POSSIBLE, not BCMA_HOST_PCI ]
>
> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
> index c1172da..6a0082d 100644
> --- a/drivers/bcma/Kconfig
> +++ b/drivers/bcma/Kconfig
> @@ -29,7 +29,7 @@ config BCMA_HOST_PCI
>
> config BCMA_DRIVER_PCI_HOSTMODE
> bool "Driver for PCI core working in hostmode"
> - depends on BCMA && MIPS
> + depends on BCMA && MIPS && BCMA_HOST_PCI_POSSIBLE
This is wrong the first patch you send was correct. Now it is possible
to select BCMA_DRIVER_PCI_HOSTMODE without selecting BCMA_DRIVER_PCI
which will cause build errors as host mode part uses bcma_pcie_read().
You should do this:
+ depends on BCMA && MIPS && BCMA_DRIVER_PCI
Maybe I should make it possible to build it with pcie host mode support,
but without pcie client mode support. For now it is not needed as all
device I know of have an other bcma device behind the pcie bus.
> help
> PCI core hostmode operation (external PCI bus).
>
> diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
> index 4e20bcf..d2097a1 100644
> --- a/drivers/bcma/driver_pci_host.c
> +++ b/drivers/bcma/driver_pci_host.c
> @@ -10,6 +10,7 @@
> */
>
> #include "bcma_private.h"
> +#include <linux/pci.h>
> #include <linux/export.h>
> #include <linux/bcma/bcma.h>
> #include <asm/paccess.h>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
2012-03-27 10:53 ` Hauke Mehrtens
@ 2012-03-27 19:27 ` Paul Gortmaker
0 siblings, 0 replies; 9+ messages in thread
From: Paul Gortmaker @ 2012-03-27 19:27 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: Julian Calaby, zajec5, linux-wireless, John W. Linville
On 12-03-27 06:53 AM, Hauke Mehrtens wrote:
> On 03/26/2012 09:56 PM, Paul Gortmaker wrote:
>> The following is seen during allmodconfig builds for MIPS:
>>
>> drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
>> of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
>> cc1: some warnings being treated as errors
>> make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1
>>
>> Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf
>>
>> "bcma: add PCIe host controller"
>>
>> Add the header instead of implicitly assuming it will be present.
>> Sounds like a good idea, but that alone doesn't fix anything.
>>
>> The real problem is that the Kconfig has settings related to whether
>> PCI is possible, i.e.
>>
>> config BCMA_HOST_PCI_POSSIBLE
>> bool
>> depends on BCMA && PCI = y
>> default y
>>
>> config BCMA_HOST_PCI
>> bool "Support for BCMA on PCI-host bus"
>> depends on BCMA_HOST_PCI_POSSIBLE
>>
>> ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
>> have any dependencies on the above. Add one.
>>
>> CC: Hauke Mehrtens <hauke@hauke-m.de>
>> CC: John W. Linville <linville@tuxdriver.com>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>> ---
>>
>> [ v2: depend on BCMA_HOST_PCI_POSSIBLE, not BCMA_HOST_PCI ]
>>
>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
>> index c1172da..6a0082d 100644
>> --- a/drivers/bcma/Kconfig
>> +++ b/drivers/bcma/Kconfig
>> @@ -29,7 +29,7 @@ config BCMA_HOST_PCI
>>
>> config BCMA_DRIVER_PCI_HOSTMODE
>> bool "Driver for PCI core working in hostmode"
>> - depends on BCMA && MIPS
>> + depends on BCMA && MIPS && BCMA_HOST_PCI_POSSIBLE
>
> This is wrong the first patch you send was correct. Now it is possible
> to select BCMA_DRIVER_PCI_HOSTMODE without selecting BCMA_DRIVER_PCI
> which will cause build errors as host mode part uses bcma_pcie_read().
>
> You should do this:
> + depends on BCMA && MIPS && BCMA_DRIVER_PCI
OK, the text in your follow-up here was confusing.
http://marc.info/?l=linux-wireless&m=133276175202412&w=2
It made me think you agreed with the proposed correction
and wanted a v2, vs. agreeing with my v1 interpretation.
If John can grab the v1 and your ack'd by from here:
http://marc.info/?l=linux-wireless&m=133272031621916&w=2
then great. I'll leave it in the hands of the wireless
folks from here.
Paul.
>
> Maybe I should make it possible to build it with pcie host mode support,
> but without pcie client mode support. For now it is not needed as all
> device I know of have an other bcma device behind the pcie bus.
>
>> help
>> PCI core hostmode operation (external PCI bus).
>>
>> diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
>> index 4e20bcf..d2097a1 100644
>> --- a/drivers/bcma/driver_pci_host.c
>> +++ b/drivers/bcma/driver_pci_host.c
>> @@ -10,6 +10,7 @@
>> */
>>
>> #include "bcma_private.h"
>> +#include <linux/pci.h>
>> #include <linux/export.h>
>> #include <linux/bcma/bcma.h>
>> #include <asm/paccess.h>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-03-27 19:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-26 0:02 [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device Paul Gortmaker
2012-03-26 0:13 ` Julian Calaby
2012-03-26 1:20 ` Paul Gortmaker
2012-03-26 1:28 ` Julian Calaby
2012-03-26 11:34 ` Hauke Mehrtens
2012-03-26 18:56 ` Paul Gortmaker
2012-03-27 10:53 ` Hauke Mehrtens
2012-03-27 19:27 ` Paul Gortmaker
2012-03-26 11:30 ` Hauke Mehrtens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).