[rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[Chen, Chien-Chia]

Move rt2x00rfkill_register(rt2x00dev) to rt2x00lib_probe_dev().
It fixes of starting rfkill_poll function at the right time if
sets hard rfkill block and reboot. rt2x00mac_rfkill_poll should
be starting before bringing up the wireless interface.

Signed-off-by: Kevin Chou <kevin.chou@mediatek.com>
---
 drivers/net/wireless/rt2x00/rt2x00dev.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index fc9901e..90cc5e7 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -1062,11 +1062,6 @@ static int rt2x00lib_initialize(struct rt2x00_dev *rt2x00dev)
 
 	set_bit(DEVICE_STATE_INITIALIZED, &rt2x00dev->flags);
 
-	/*
-	 * Register the extra components.
-	 */
-	rt2x00rfkill_register(rt2x00dev);
-
 	return 0;
 }
 
@@ -1210,6 +1205,7 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
 	rt2x00link_register(rt2x00dev);
 	rt2x00leds_register(rt2x00dev);
 	rt2x00debug_register(rt2x00dev);
+	rt2x00rfkill_register(rt2x00dev);
 
 	return 0;
 
-- 
1.7.3.4

Re: [rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[Helmut Schaa]

On Tue, Mar 27, 2012 at 8:28 AM, Chen, Chien-Chia <machen@suse.com> wrote:
> Move rt2x00rfkill_register(rt2x00dev) to rt2x00lib_probe_dev().
> It fixes of starting rfkill_poll function at the right time if
> sets hard rfkill block and reboot. rt2x00mac_rfkill_poll should
> be starting before bringing up the wireless interface.

Looks reasonable to me. However, you should include John Linville in future
patch submissions (if your intention is to get them merged :D and not only
reviewed).

Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>

> Signed-off-by: Kevin Chou <kevin.chou@mediatek.com>
> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index fc9901e..90cc5e7 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1062,11 +1062,6 @@ static int rt2x00lib_initialize(struct rt2x00_dev *rt2x00dev)
>
>        set_bit(DEVICE_STATE_INITIALIZED, &rt2x00dev->flags);
>
> -       /*
> -        * Register the extra components.
> -        */
> -       rt2x00rfkill_register(rt2x00dev);
> -
>        return 0;
>  }
>
> @@ -1210,6 +1205,7 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
>        rt2x00link_register(rt2x00dev);
>        rt2x00leds_register(rt2x00dev);
>        rt2x00debug_register(rt2x00dev);
> +       rt2x00rfkill_register(rt2x00dev);
>
>        return 0;
>
> --
> 1.7.3.4
>

Re: [rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[Stanislaw Gruszka]

On Tue, Mar 27, 2012 at 02:28:00PM +0800, Chen, Chien-Chia wrote:
> Move rt2x00rfkill_register(rt2x00dev) to rt2x00lib_probe_dev().
> It fixes of starting rfkill_poll function at the right time if
> sets hard rfkill block and reboot. rt2x00mac_rfkill_poll should
> be starting before bringing up the wireless interface.
> 
> Signed-off-by: Kevin Chou <kevin.chou@mediatek.com>
You should sign off the patch, and probably add "From:" to mark real
author of the patch, and CC Kevin as well.

Stanislaw

Re: [rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[Matt Chen]

Hi all,

2012/3/27 Stanislaw Gruszka <sgruszka@redhat.com>:
> On Tue, Mar 27, 2012 at 02:28:00PM +0800, Chen, Chien-Chia wrote:
>> Move rt2x00rfkill_register(rt2x00dev) to rt2x00lib_probe_dev().
>> It fixes of starting rfkill_poll function at the right time if
>> sets hard rfkill block and reboot. rt2x00mac_rfkill_poll should
>> be starting before bringing up the wireless interface.
>>
>> Signed-off-by: Kevin Chou <kevin.chou@mediatek.com>
> You should sign off the patch, and probably add "From:" to mark real
> author of the patch, and CC Kevin as well.
Yes, thank you for information of patch format. :)
> Stanislaw
>
> _______________________________________________
> users mailing list
> users@rt2x00.serialmonkey.com
> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
>



-- 
Thank you.

Re: [rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[Matt Chen]

Hi John,

Would it be possible to merge my patch to v3.4 merging ？
It would be great if this patch got merged. This patch fixes an
initialization of probing pci device. Since a lot users reported the
issue is making no sense after rebooting the machine and got No
wireless device working due to rfkill is not yet started to work.

Thank you for your kindly help. :)

Would it be possible to merge this patch into v3.4 tree before the
merging window closed ?

2012/3/28 Matt Chen <machen@suse.com>:
> Hi all,
>
> 2012/3/27 Stanislaw Gruszka <sgruszka@redhat.com>:
>> On Tue, Mar 27, 2012 at 02:28:00PM +0800, Chen, Chien-Chia wrote:
>>> Move rt2x00rfkill_register(rt2x00dev) to rt2x00lib_probe_dev().
>>> It fixes of starting rfkill_poll function at the right time if
>>> sets hard rfkill block and reboot. rt2x00mac_rfkill_poll should
>>> be starting before bringing up the wireless interface.
>>>
>>> Signed-off-by: Kevin Chou <kevin.chou@mediatek.com>
>> You should sign off the patch, and probably add "From:" to mark real
>> author of the patch, and CC Kevin as well.
> Yes, thank you for information of patch format. :)
>> Stanislaw
>>
>> _______________________________________________
>> users mailing list
>> users@rt2x00.serialmonkey.com
>> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
>>
>
>
>
> --
> Thank you.



-- 
Thank you.

Re: [rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[Stanislaw Gruszka]

On Thu, Mar 29, 2012 at 10:50:25AM +0800, Matt Chen wrote:
> Hi John,
> 
> Would it be possible to merge my patch to v3.4 merging ？
> It would be great if this patch got merged. This patch fixes an
> initialization of probing pci device. Since a lot users reported the
> issue is making no sense after rebooting the machine and got No
> wireless device working due to rfkill is not yet started to work.
> 
> Thank you for your kindly help. :)
> 
> Would it be possible to merge this patch into v3.4 tree before the
> merging window closed ?
Since patch is a fix, it could be applied after merge window. But first
you should fix sign-off's and repost.

Stanislaw

Re: [rt2x00-users] [PATCH] rt2x00: rt2x00dev: move rfkill_polling register to proper place

[Matt Chen]

Hi Stanislaw,

2012/3/29 Stanislaw Gruszka <sgruszka@redhat.com>:
> On Thu, Mar 29, 2012 at 10:50:25AM +0800, Matt Chen wrote:
>> Hi John,
>>
>> Would it be possible to merge my patch to v3.4 merging ？
>> It would be great if this patch got merged. This patch fixes an
>> initialization of probing pci device. Since a lot users reported the
>> issue is making no sense after rebooting the machine and got No
>> wireless device working due to rfkill is not yet started to work.
>>
>> Thank you for your kindly help. :)
>>
>> Would it be possible to merge this patch into v3.4 tree before the
>> merging window closed ?
> Since patch is a fix, it could be applied after merge window. But first
> you should fix sign-off's and repost.
OK, repost and also mail to John.
Thanks for your reminding. :)
> Stanislaw
>



-- 
Thank you.