Re: [PATCH 1/2] rt2x00: configure different txdesc parameters for non HT channel

[Stanislaw Gruszka <sgruszka@redhat.com>]

Hello

On Mon, Apr 02, 2012 at 02:09:14PM +0200, Helmut Schaa wrote:
> Why should we use PIFS for the beacon? Is that what the ralink drivers
> are doing?
Hmm, seems that is my own invention. I thought that should be used for
beacons, but currently I can only find in docs, that this is only needed
for entering PCF.
 
> > +               else if (!(tx_info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT))
> > +                       txdesc->u.ht.txop = TXOP_SIFS;
> > +               else
> > +                       txdesc->u.ht.txop = TXOP_BACKOFF;
> > +
> > +               txdesc->u.ht.mcs = txrate->idx;
> > +
> 
> This lacks short preamble handling. Something like:
> 
> if (txrate->flags & IEEE80211_TX_RC_USE_SHORT_PREAMBLE)
>   txdesc->u.ht.mcs |= 0x08;
> 
> Actually, you could just shuffle the code a bit such that the rate setup
> happens before all the HT stuff, no?
Make sense.

Stanislaw