From: Pavel Roskin <proski@gnu.org>
To: Jonathan Bither <jonbither@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] ath5k: add missing iounmap to AHB probe removal
Date: Tue, 24 Apr 2012 17:05:05 -0400 [thread overview]
Message-ID: <20120424170505.51687253@mj> (raw)
In-Reply-To: <4F96704F.8050406@gmail.com>
On Tue, 24 Apr 2012 05:20:15 -0400
Jonathan Bither <jonbither@gmail.com> wrote:
> When our driver device is removed on the AHB bus, our IO memory is
> never unmapped.
>
> Signed-off-by: Jonathan Bither <jonbither@gmail.com>
>
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c
> b/drivers/net/wireless/ath/ath5k/ahb.c index 8c50d9d..aec33cc 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -220,6 +220,7 @@ static int ath_ahb_remove(struct platform_device
> *pdev) }
>
> ath5k_deinit_ah(ah);
> + iounmap(ah->iobase);
> platform_set_drvdata(pdev, NULL);
> ieee80211_free_hw(hw);
Reviewed-by: Pavel Roskin <proski@gnu.org>
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2012-04-24 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 9:20 [PATCH V2] ath5k: add missing iounmap to AHB probe removal Jonathan Bither
2012-04-24 21:05 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424170505.51687253@mj \
--to=proski@gnu.org \
--cc=jonbither@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox