* [PATCH V2] ath5k: add missing iounmap to AHB probe removal
@ 2012-04-24 9:20 Jonathan Bither
2012-04-24 21:05 ` Pavel Roskin
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Bither @ 2012-04-24 9:20 UTC (permalink / raw)
To: linux-wireless
When our driver device is removed on the AHB bus, our IO memory is never unmapped.
Signed-off-by: Jonathan Bither <jonbither@gmail.com>
diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
index 8c50d9d..aec33cc 100644
--- a/drivers/net/wireless/ath/ath5k/ahb.c
+++ b/drivers/net/wireless/ath/ath5k/ahb.c
@@ -220,6 +220,7 @@ static int ath_ahb_remove(struct platform_device *pdev)
}
ath5k_deinit_ah(ah);
+ iounmap(ah->iobase);
platform_set_drvdata(pdev, NULL);
ieee80211_free_hw(hw);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] ath5k: add missing iounmap to AHB probe removal
2012-04-24 9:20 [PATCH V2] ath5k: add missing iounmap to AHB probe removal Jonathan Bither
@ 2012-04-24 21:05 ` Pavel Roskin
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Roskin @ 2012-04-24 21:05 UTC (permalink / raw)
To: Jonathan Bither; +Cc: linux-wireless
On Tue, 24 Apr 2012 05:20:15 -0400
Jonathan Bither <jonbither@gmail.com> wrote:
> When our driver device is removed on the AHB bus, our IO memory is
> never unmapped.
>
> Signed-off-by: Jonathan Bither <jonbither@gmail.com>
>
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c
> b/drivers/net/wireless/ath/ath5k/ahb.c index 8c50d9d..aec33cc 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -220,6 +220,7 @@ static int ath_ahb_remove(struct platform_device
> *pdev) }
>
> ath5k_deinit_ah(ah);
> + iounmap(ah->iobase);
> platform_set_drvdata(pdev, NULL);
> ieee80211_free_hw(hw);
Reviewed-by: Pavel Roskin <proski@gnu.org>
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-24 21:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-24 9:20 [PATCH V2] ath5k: add missing iounmap to AHB probe removal Jonathan Bither
2012-04-24 21:05 ` Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).