From: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: <johannes@sipsolutions.net>, <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: fix rate control update on 2040 bss change
Date: Wed, 25 Apr 2012 20:14:06 +0530 [thread overview]
Message-ID: <20120425144405.GA890@vmraj-lnx.users.atheros.com> (raw)
In-Reply-To: <4F980551.3070204@broadcom.com>
On Wed, Apr 25, 2012 at 04:08:17PM +0200, Arend van Spriel wrote:
> On 04/25/2012 03:01 PM, Rajkumar Manoharan wrote:
> >The rate control updatation never be called on 2040 BSS change.
>
> 'updatation' == typo?
>
yep. thanks
> >The station should update its rate control on receiving beacon
> >with different HT mode in the HT operation IE. Not doing so,
> >leads to sending frames with higher(ht40) rates whereas AP is
> >running in lower mode (ht20).
> >
> >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
> >---
> > net/mac80211/mlme.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> >index c8836fa..56128d3 100644
> >--- a/net/mac80211/mlme.c
> >+++ b/net/mac80211/mlme.c
> >@@ -210,7 +210,7 @@ static u32 ieee80211_config_ht_tx(struct ieee80211_sub_if_data *sdata,
> > disable_40 = true;
> >
> > if (sta&& (!reconfig ||
> >- (disable_40 != !!(sta->sta.ht_cap.cap&
> >+ (disable_40 == !!(sta->sta.ht_cap.cap&
> > IEEE80211_HT_CAP_SUP_WIDTH_20_40)))) {
> >
Jouni,
To make it more readable, will change as follows
+ (disable_40 != !(sta->sta.ht_cap.cap&
-Rajkumar
prev parent reply other threads:[~2012-04-25 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 13:01 [RFC] mac80211: fix rate control update on 2040 bss change Rajkumar Manoharan
2012-04-25 14:08 ` Arend van Spriel
2012-04-25 14:44 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425144405.GA890@vmraj-lnx.users.atheros.com \
--to=rmanohar@qca.qualcomm.com \
--cc=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox