linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/nfc: Fix the compilation warning
@ 2012-04-30  7:43 joseph daniel
  2012-04-30  9:15 ` Samuel Ortiz
  0 siblings, 1 reply; 2+ messages in thread
From: joseph daniel @ 2012-04-30  7:43 UTC (permalink / raw)
  To: Lauro Ramos Venancio, Aloisio Almeida Jr, Samuel Ortiz,
	David S. Miller, linux-wireless, netdev, linux-kernel
  Cc: joseph daniel

the nfc_llcp_general_bytes is defined in nfc/core.c as
    static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, size_t *gb_len).

as in nfc/nfc.h:
    static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, u8 *gb_len), as
    CONFIG_NFC_LLCP is not defined.

so we got some warnings,
net/nfc/core.c:207:2: warning: passing argument 2 of ‘nfc_llcp_general_bytes’ from incompatible pointer type [enabled by default]
net/nfc/nfc.h:87:19: note: expected ‘u8 *’ but argument is of type ‘size_t *’

Signed-off-by: joseph daniel <josephdanielwalter@gmail.com>
---
 net/nfc/nfc.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/nfc/nfc.h b/net/nfc/nfc.h
index ec8794c..549382c 100644
--- a/net/nfc/nfc.h
+++ b/net/nfc/nfc.h
@@ -84,7 +84,7 @@ static inline int nfc_llcp_set_remote_gb(struct nfc_dev *dev,
 	return 0;
 }
 
-static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, u8 *gb_len)
+static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, size_t *gb_len)
 {
 	*gb_len = 0;
 	return NULL;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/nfc: Fix the compilation warning
  2012-04-30  7:43 [PATCH] net/nfc: Fix the compilation warning joseph daniel
@ 2012-04-30  9:15 ` Samuel Ortiz
  0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2012-04-30  9:15 UTC (permalink / raw)
  To: joseph daniel
  Cc: Lauro Ramos Venancio, Aloisio Almeida Jr, David S. Miller,
	linux-wireless, netdev, linux-kernel

Hi Joseph,

On Mon, Apr 30, 2012 at 01:43:15PM +0600, joseph daniel wrote:
> the nfc_llcp_general_bytes is defined in nfc/core.c as
>     static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, size_t *gb_len).
> 
> as in nfc/nfc.h:
>     static inline u8 *nfc_llcp_general_bytes(struct nfc_dev *dev, u8 *gb_len), as
>     CONFIG_NFC_LLCP is not defined.
> 
> so we got some warnings,
> net/nfc/core.c:207:2: warning: passing argument 2 of ‘nfc_llcp_general_bytes’ from incompatible pointer type [enabled by default]
> net/nfc/nfc.h:87:19: note: expected ‘u8 *’ but argument is of type ‘size_t *’
> 
> Signed-off-by: joseph daniel <josephdanielwalter@gmail.com>
Thanks, patch applied to my nfc-next branch.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-30  9:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-30  7:43 [PATCH] net/nfc: Fix the compilation warning joseph daniel
2012-04-30  9:15 ` Samuel Ortiz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).