linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers
Date: Thu, 3 May 2012 09:34:47 -0400	[thread overview]
Message-ID: <20120503133447.GG9285@tuxdriver.com> (raw)
In-Reply-To: <1336021968-19478-1-git-send-email-marcel@holtmann.org>

Was there a [PATCH 1/2]?  I didn't get it...

On Thu, May 03, 2012 at 07:12:48AM +0200, Marcel Holtmann wrote:
> The SHDLC link layer of HCI based drivers uses CRC-CCITT and thus
> needs to select that kernel option.
> 
> Otherwise it ends up with this linking error:
> 
> net/built-in.o: In function `nfc_shdlc_add_len_crc':
> net/nfc/hci/shdlc.c:113: undefined reference to `crc_ccitt'
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  net/nfc/hci/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/nfc/hci/Kconfig b/net/nfc/hci/Kconfig
> index 17213a6..fd67f51 100644
> --- a/net/nfc/hci/Kconfig
> +++ b/net/nfc/hci/Kconfig
> @@ -9,6 +9,7 @@ config NFC_HCI
>  
>  config NFC_SHDLC
>  	depends on NFC_HCI
> +	select CRC_CCITT
>  	bool "SHDLC link layer for HCI based NFC drivers"
>  	default n
>  	---help---
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2012-05-03 13:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03  5:12 [PATCH 2/2] NFC: Select CRC_CCITT for SHDLC link layer of HCI based drivers Marcel Holtmann
2012-05-03 13:34 ` John W. Linville [this message]
2012-05-03 20:36   ` Marcel Holtmann
2012-05-07  8:23 ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120503133447.GG9285@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).