From: David Miller <davem@davemloft.net>
To: gustavo@padovan.org
Cc: linville@tuxdriver.com, linux-bluetooth@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix coding style
Date: Mon, 07 May 2012 11:56:55 -0400 (EDT) [thread overview]
Message-ID: <20120507.115655.1099092499206396209.davem@davemloft.net> (raw)
In-Reply-To: <20120507152113.GA5192@joana>
From: Gustavo Padovan <gustavo@padovan.org>
Date: Mon, 7 May 2012 12:24:05 -0300
> * David Miller <davem@davemloft.net> [2012-05-06 12:36:56 -0400]:
>
>> From: Gustavo Padovan <gustavo@padovan.org>
>> Date: Fri, 4 May 2012 15:59:48 -0300
>>
>> > Fix offending styles all over the tree. This is in conformance David
>> > Miller's style rules.
>>
>> They aren't just my style rules.
>>
>> And, if your plan is to patch things up afterwards so you don't
>> have to change existing commits in your tree, think again.
>>
>> I absolutely will not pull a tree from John that has commits in
>> it that add the bad indentation.
>>
>> You have to respin your tree with fixed commits.
>
> John, can you please unpull the bluetooth tree from wireless-next? I'll be
> fixing he affected commits and the send you a new pull request. Thanks.
And John also make sure these guys don't add unreasonable commit log
messages saying things like that this multi-line condition style thing
is my specific coding style. It's not.
prev parent reply other threads:[~2012-05-07 15:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 18:59 [PATCH] Bluetooth: Fix coding style Gustavo Padovan
2012-05-06 16:02 ` Marcel Holtmann
2012-05-06 16:36 ` David Miller
2012-05-06 17:46 ` David Herrmann
2012-05-06 18:53 ` David Miller
2012-05-07 8:14 ` Andrei Emeltchenko
2012-05-07 8:21 ` Arend van Spriel
2012-05-07 8:29 ` Andrei Emeltchenko
2012-05-07 10:06 ` Arend van Spriel
2012-05-07 15:52 ` David Miller
2012-05-07 19:49 ` Lucas De Marchi
2012-05-07 20:06 ` David Miller
2012-05-07 20:14 ` Arend van Spriel
2012-05-07 21:33 ` Marcel Holtmann
2012-05-07 21:41 ` David Miller
2012-05-07 17:06 ` Marcel Holtmann
2012-05-07 17:55 ` David Miller
2012-05-07 21:22 ` Marcel Holtmann
2012-05-07 23:24 ` Joe Perches
2012-05-07 19:40 ` Lucas De Marchi
2012-05-07 15:24 ` Gustavo Padovan
2012-05-07 15:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507.115655.1099092499206396209.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).