From: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
To: Hewitt Lee <hewittl@synology.com>
Cc: Jouni Malinen <jouni@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
<linux-wireless@vger.kernel.org>, <ath9k-devel@lists.ath9k.org>,
Synology/KueiHuan Chen <khchen@synology.com>,
andysuper Wang <minhongw@synology.com>
Subject: Re: [PATCH] ath9k : stability issue in a noisy environment
Date: Thu, 10 May 2012 16:55:56 -0700 [thread overview]
Message-ID: <20120510235556.GB26950@tux> (raw)
In-Reply-To: <CABCXq82J7UL2y6Zzt=Rm8XgAdnQeVMp4xOG-fnVU1uFEmooyZQ@mail.gmail.com>
On Wed, May 09, 2012 at 08:12:38PM +0800, Hewitt Lee wrote:
> Hi All,
> This patch unlink a skb comes from ath_tx_form_aggr() which is freed at
> ath_tx_get_buffer() when tx buffers are full.
> Please kindly review it.
Please see:
http://wireless.kernel.org/en/developers/Documentation/SubmittingPatches
Also please provide a clear description of what you are trying to fix,
what happens without the patch, what happens with the patch. My review
below.
> Thanks.
> diff --git a/v3.3.x/drivers/net/wireless/ath/ath9k/xmit.c
> b/v3.3.x/drivers/net/wireless/ath/ath9k/xmit.c
> old mode 100644
> new mode 100755
> index 3182408..f4e1e62
> --- a/v3.3.x/drivers/net/wireless/ath/ath9k/xmit.c
> +++ b/v3.3.x/drivers/net/wireless/ath/ath9k/xmit.c
> @@ -1858,6 +1858,12 @@ static struct ath_buf *ath_tx_setup_buffer(struct
> ath_softc *sc,
> return bf;
>
> error:
> + if (tid) {
> + if (skb == skb_peek(&tid->buf_q)) {
> + __skb_unlink(skb, &tid->buf_q);
> + }
> + }
> +
> dev_kfree_skb_any(skb);
> return NULL;
> }
Yeah I have no idea why you are doing this here, based on your description
the skb will be free'd at ath_tx_get_buffer() but ath_tx_get_buffer()
does not free anything. Can you please be sure to check first against
the latest development tree for 802.11 first?
Luis
parent reply other threads:[~2012-05-10 23:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CABCXq82J7UL2y6Zzt=Rm8XgAdnQeVMp4xOG-fnVU1uFEmooyZQ@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510235556.GB26950@tux \
--to=rodrigue@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=hewittl@synology.com \
--cc=jouni@qca.qualcomm.com \
--cc=khchen@synology.com \
--cc=linux-wireless@vger.kernel.org \
--cc=minhongw@synology.com \
--cc=senthilb@qca.qualcomm.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).