From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: fix single queue drivers
Date: Mon, 14 May 2012 13:56:04 -0400 [thread overview]
Message-ID: <20120514175603.GB2428@tuxdriver.com> (raw)
In-Reply-To: <4FAF3AB8.90900@lwfinger.net>
On Sat, May 12, 2012 at 11:38:16PM -0500, Larry Finger wrote:
> On 05/07/2012 10:45 AM, Johannes Berg wrote:
> >From: Johannes Berg<johannes.berg@intel.com>
> >
> >My queue management rework broke drivers that don't
> >have multiple AC queues and register a single queue
> >only, causing a warning:
> >
> >WARNING: at net/mac80211/iface.c:162 ieee80211_check_queues
> >
> >This was due to filling the queues wrongly and then
> >noticing the error when checking later.
> >
> >Reported-and-Tested-by: Larry Finger<Larry.Finger@lwfinger.net>
> >Signed-off-by: Johannes Berg<johannes.berg@intel.com>
>
> John,
>
> I know you have been busy and that Linus is restricting the patches
> to be added after 3.4-rc7; however, this one really needs to get
> into 3.4. If it does not make it, every wireless device with only
> one hardware queue will break.
>
> Larry
Actually, it doesn't seem to apply in 3.4. The original commit that
causes the problem (3a25a8c8) seems to only exist in wireless-next.
Is there some other version of this patch to apply for 3.4?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-05-14 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 15:45 [PATCH] mac80211: fix single queue drivers Johannes Berg
2012-05-13 4:38 ` Larry Finger
2012-05-14 17:56 ` John W. Linville [this message]
2012-05-14 19:11 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514175603.GB2428@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).