From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: joe@perches.com, netdev@vger.kernel.org,
linux-decnet-user@lists.sourceforge.net,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, linux-wireless@vger.kernel.org,
dev@openvswitch.org, linux-sctp@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC net-next 0/2] net: Use net_<level>_ratelimit
Date: Tue, 15 May 2012 14:29:22 -0400 (EDT) [thread overview]
Message-ID: <20120515.142922.1434224550630736456.davem@davemloft.net> (raw)
In-Reply-To: <1337106430.15553.6.camel@jlt3.sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 15 May 2012 20:27:10 +0200
> On Tue, 2012-05-15 at 10:59 -0700, Joe Perches wrote:
>
>> OK, but fyi, there's a possible issue with !CONFIG_DEBUG
>> builds because these patches converted some uses of
>> if (net_ratelimit())
>> printk(KERN_DEBUG ...
>> to
>> net_dbg_ratelimited()
>>
>> These messages are no longer emitted when DEBUG isn't defined
>> and not using dynamic_debug. I'm not sure that's a real
>> problem, but it's a difference.
>>
>> I could produce a net_printk_ratelimited that would keep
>> the original behavior if necessary.
>>
>> net_printk_ratelimited(KERN_DEBUG etc...)
>
> Btw, what would the difference be to just plain printk_ratelimited()?
printk_ratelimited() drops a local ratelimit cookie into each call-site,
whereas we have a global one for the networking which these new interfaces
use.
Joe explained this completely in his 0/2 patch posting.
next prev parent reply other threads:[~2012-05-15 18:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 7:56 [RFC net-next 0/2] net: Use net_<level>_ratelimit Joe Perches
2012-05-14 7:56 ` [RFC net-next 2/2] net: Convert net_ratelimit uses to net_<level>_ratelimited Joe Perches
2012-05-15 17:45 ` [RFC net-next 0/2] net: Use net_<level>_ratelimit David Miller
2012-05-15 17:59 ` Joe Perches
2012-05-15 18:03 ` Johannes Berg
2012-05-15 18:13 ` David Miller
2012-05-15 18:21 ` Johannes Berg
2012-05-15 18:24 ` David Miller
2012-05-15 18:29 ` Johannes Berg
2012-05-15 18:30 ` David Miller
2012-05-15 21:20 ` [PATCH 0/3] net: mac80211: Neaten debugging Joe Perches
2012-05-15 21:20 ` [PATCH 1/3] net: mac80211: Convert printk(KERN_DEBUG to pr_debug Joe Perches
2012-05-15 21:20 ` [PATCH 2/3] net: mac80211: Add and use ht_vdbg debugging macro Joe Perches
2012-05-15 21:20 ` [PATCH 3/3] net: mac80211: Add and use ibss_vdbg " Joe Perches
2012-05-16 5:23 ` [PATCH 0/3] net: mac80211: Neaten debugging David Miller
2012-05-16 7:59 ` Johannes Berg
2012-05-16 15:22 ` Joe Perches
2012-05-16 15:30 ` Johannes Berg
2012-05-16 15:43 ` Joe Perches
2012-05-16 15:56 ` Johannes Berg
2012-05-15 18:14 ` [RFC net-next 0/2] net: Use net_<level>_ratelimit David Miller
2012-05-15 18:27 ` Johannes Berg
2012-05-15 18:29 ` David Miller [this message]
2012-05-15 18:40 ` Johannes Berg
2012-05-15 18:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515.142922.1434224550630736456.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=coreteam@netfilter.org \
--cc=dev@openvswitch.org \
--cc=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).