linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kubakici@wp.pl>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
	"Alex Villací­s Lasso" <a_villacis@palosanto.com>
Subject: Re: [PATCH] rt2x00: Add support for RT5360 based PCI devices.
Date: Tue, 15 May 2012 12:22:57 +0200	[thread overview]
Message-ID: <20120515122257.1e58ee43@north> (raw)
In-Reply-To: <1336652854-16163-1-git-send-email-gwingerde@gmail.com>

Hi,

On Thu, 10 May 2012 14:27:33 +0200 Gertjan van Wingerde <gwingerde@gmail.com> wrote:
> From: Alex Villací­s Lasso <a villacis@palosanto.com>
> 
> This chip is used at least by the D-Link DWA-525 adapter.

I have some concerns regarding this patch. 

First of all Gertjan, I think you removed define of RF5360 and it
doesn't compile now ;-)

Secondly looking at legacy driver, 5360 is just another PCI ID of 5390
family, do we really need to add all these cases? I think maybe adding
PCI ID, as Zero Lin did recently with 539b will be sufficient? 

  -- Kuba

  parent reply	other threads:[~2012-05-15 10:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 12:27 [PATCH] rt2x00: Add support for RT5360 based PCI devices Gertjan van Wingerde
2012-05-10 12:35 ` Ivo Van Doorn
2012-05-15 10:22 ` Jakub Kicinski [this message]
2012-05-15 18:30   ` Gertjan van Wingerde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120515122257.1e58ee43@north \
    --to=kubakici@wp.pl \
    --cc=a_villacis@palosanto.com \
    --cc=gwingerde@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).