Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jouni Malinen <j@w1.fi>
To: Eliad Peller <eliad@wizery.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: retry auth and assoc on error 17
Date: Tue, 15 May 2012 11:16:25 -0400	[thread overview]
Message-ID: <20120515151625.GA1306@w1.fi> (raw)
In-Reply-To: <CAB3XZEd49R_KSAMRwM-B9PW_yzmK7aS9zzFVueA=nrFM7odC=w@mail.gmail.com>

On Tue, May 15, 2012 at 05:40:17PM +0300, Eliad Peller wrote:
> On Tue, May 15, 2012 at 5:30 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Tue, 2012-05-15 at 17:21 +0300, Eliad Peller wrote:
> >> In some congested environments APs return
> >> WLAN_STATUS_AP_UNABLE_TO_HANDLE_NEW_STA on auth/assoc
> >> attempt. Instead of failing immediately, retry again
> >> in 200 msec.
> >
> > I think this should be in wpa_supplicant?
> >
> it behaves similarly to WLAN_STATUS_ASSOC_REJECTED_TEMPORARILY, which
> handled by mac80211, so i thought it would be fine to handle it as
> well (and this way it can also be used by iw).

WLAN_STATUS_ASSOC_REJECTED_TEMPORARILY is a special case in which the AP
provides a clear expectation of the association succeeding after the
specified amount of time. WLAN_STATUS_AP_UNABLE_TO_HANDLE_NEW_STA is
quite different since it can be used by APs to enforce load balancing.
It does not sound like a good idea to enforce mac80211 to retry
association with the same AP unconditionally in this case. I would also
leave this for wpa_supplicant which has already been optimized to handle
the load balancing case without this type of extra latency added.
Disabling this functionality would not be good for many enterprise
networks.

-- 
Jouni Malinen                                            PGP id EFC895FA

  reply	other threads:[~2012-05-15 15:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 14:21 [PATCH] mac80211: retry auth and assoc on error 17 Eliad Peller
2012-05-15 14:30 ` Johannes Berg
2012-05-15 14:40   ` Eliad Peller
2012-05-15 15:16     ` Jouni Malinen [this message]
2012-05-15 15:18       ` Eliad Peller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120515151625.GA1306@w1.fi \
    --to=j@w1.fi \
    --cc=eliad@wizery.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox