From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: johannes@sipsolutions.net, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] net: mac80211: Neaten debugging
Date: Wed, 16 May 2012 01:23:19 -0400 (EDT) [thread overview]
Message-ID: <20120516.012319.1903390658912592000.davem@davemloft.net> (raw)
In-Reply-To: <cover.1337116578.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Tue, 15 May 2012 14:20:29 -0700
> Always use pr_debug variants instead of printk(KERN_DEBUG...)
>
> Joe Perches (3):
> net: mac80211: Convert printk(KERN_DEBUG to pr_debug
> net: mac80211: Add and use ht_vdbg debugging macro
> net: mac80211: Add and use ibss_vdbg debugging macro
I really think this is the right thing to do and I hope the wireless
folks integrate this.
I am well aware that you guys intend for some of these messages to be
indications and notifications the user is intended to SEE, but in the
cases where that is true KERN_DEBUG is absolutely not appropriate.
You should be using KERN_INFO or KERN_WARN in those situations
instead.
Thanks.
next prev parent reply other threads:[~2012-05-16 5:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 7:56 [RFC net-next 0/2] net: Use net_<level>_ratelimit Joe Perches
2012-05-14 7:56 ` [RFC net-next 2/2] net: Convert net_ratelimit uses to net_<level>_ratelimited Joe Perches
2012-05-15 17:45 ` [RFC net-next 0/2] net: Use net_<level>_ratelimit David Miller
2012-05-15 17:59 ` Joe Perches
2012-05-15 18:03 ` Johannes Berg
2012-05-15 18:13 ` David Miller
2012-05-15 18:21 ` Johannes Berg
2012-05-15 18:24 ` David Miller
2012-05-15 18:29 ` Johannes Berg
2012-05-15 18:30 ` David Miller
2012-05-15 21:20 ` [PATCH 0/3] net: mac80211: Neaten debugging Joe Perches
2012-05-15 21:20 ` [PATCH 1/3] net: mac80211: Convert printk(KERN_DEBUG to pr_debug Joe Perches
2012-05-15 21:20 ` [PATCH 2/3] net: mac80211: Add and use ht_vdbg debugging macro Joe Perches
2012-05-15 21:20 ` [PATCH 3/3] net: mac80211: Add and use ibss_vdbg " Joe Perches
2012-05-16 5:23 ` David Miller [this message]
2012-05-16 7:59 ` [PATCH 0/3] net: mac80211: Neaten debugging Johannes Berg
2012-05-16 15:22 ` Joe Perches
2012-05-16 15:30 ` Johannes Berg
2012-05-16 15:43 ` Joe Perches
2012-05-16 15:56 ` Johannes Berg
2012-05-15 18:14 ` [RFC net-next 0/2] net: Use net_<level>_ratelimit David Miller
2012-05-15 18:27 ` Johannes Berg
2012-05-15 18:29 ` David Miller
2012-05-15 18:40 ` Johannes Berg
2012-05-15 18:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516.012319.1903390658912592000.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).