Re: NFC: Initial LLCP support

[Dan Carpenter <dan.carpenter@oracle.com>]

On Fri, Dec 16, 2011 at 11:26:59PM +0300, Dan Carpenter wrote:
> Hello Samuel Ortiz,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch d646960f7986: "NFC: Initial LLCP support" from Dec 14, 
> 2011, leads to the following Smatch complaint:
> 
> net/nfc/llcp/sock.c +47 llcp_sock_bind()
> 	 warn: variable dereferenced before check 'addr' (see line 45)
> 
> net/nfc/llcp/sock.c
>     44	
>     45		pr_debug("sk %p addr %p family %d\n", sk, addr, addr->sa_family);
>                                                                 ^^^^^^^^^^^^^^^
> New dereference.
> 
>     46	
>     47		if (!addr || addr->sa_family != AF_NFC)
>                      ^^^^
> New check.
> 

This got lost in the holiday season.  Probably the check can just be
remove, yes?

regards,
dan carpenter

>     48			return -EINVAL;
>     49	
> 
> regards,
> dan carpenter
>