From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Zero Lin <zero.lin.0203@gmail.com>, Woody Hung <Woody.Hung@mediatek.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org,
John Linville <linville@tuxdriver.com>,
"Zero.Lin" <Zero.Lin@mediatek.com>
Subject: Re: [PATCH] rt2x00:Add RT5392 chipset support
Date: Tue, 29 May 2012 14:35:03 +0200 [thread overview]
Message-ID: <20120529123502.GD2441@redhat.com> (raw)
In-Reply-To: <1338279069-5630-1-git-send-email-zero.lin.0203@gmail.com>
On Tue, May 29, 2012 at 04:11:09PM +0800, Zero Lin wrote:
> From: "Zero.Lin" <Zero.Lin@mediatek.com>
Patch looks good for me.
> Signed-off-by: Zero.Lin <Zero.Lin@mediatek.com>
Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
> + if (rt2x00_rt(rt2x00dev, RT5392)) {
> + rt2800_rfcsr_read(rt2x00dev, 50, &rfcsr);
> + if (info->default_power1 > RT5390_POWER_BOUND)
> + rt2x00_set_field8(&rfcsr, RFCSR50_TX,
> + RT5390_POWER_BOUND);
Woody, your current RT3290 patch will conflict with that one, since you
changed RT5390_POWER_BOUND to POWER_BOUND. Please rebase your patch on
top of it, as this one will most likely be applied earlier.
Thanks
Stanislaw
prev parent reply other threads:[~2012-05-29 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 8:11 [PATCH] rt2x00:Add RT5392 chipset support Zero Lin
2012-05-29 12:35 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529123502.GD2441@redhat.com \
--to=sgruszka@redhat.com \
--cc=Woody.Hung@mediatek.com \
--cc=Zero.Lin@mediatek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
--cc=zero.lin.0203@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).