From: Sebastian Kemper <sebastian_ml@gmx.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: IWLWIFI should depend on SUSPEND
Date: Mon, 4 Jun 2012 22:31:24 +0200 [thread overview]
Message-ID: <20120604203124.GA2030@wolfgang> (raw)
In-Reply-To: <1338748437.15431.0.camel@jlt3.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On Sun, Jun 03, 2012 at 08:33:57PM +0200, Johannes Berg wrote:
> You're right, it should be CONFIG_PM_SLEEP or something ... I'll have to
> sort it out. It looks like in iwlwifi, the suspend/resume methods are
> under CONFIG_PM_SLEEP, while in mac80211 they're under CONFIG_PM.
Hello Johannes,
I changed the file iwl-agn.c according to your instructions (with #ifdef
CONFIG_PM_SLEEP) for kernel 3.2.18 (patch attached). It works, the error
is gone and wireless is available.
Thank you for your work!
Kind regards,
Sebastian
[-- Attachment #2: iwl-agn.c.2.6.18.suspend.diff --]
[-- Type: text/plain, Size: 644 bytes --]
--- drivers/net/wireless/iwlwifi/iwl-agn.c.orig 2012-06-04 18:02:32.996662801 +0200
+++ drivers/net/wireless/iwlwifi/iwl-agn.c 2012-06-04 18:03:10.539993094 +0200
@@ -1696,6 +1696,7 @@
WIPHY_FLAG_DISABLE_BEACON_HINTS |
WIPHY_FLAG_IBSS_RSN;
+#ifdef CONFIG_PM_SLEEP
if (priv->ucode_wowlan.code.len && device_can_wakeup(bus(priv)->dev)) {
hw->wiphy->wowlan.flags = WIPHY_WOWLAN_MAGIC_PKT |
WIPHY_WOWLAN_DISCONNECT |
@@ -1712,6 +1713,7 @@
hw->wiphy->wowlan.pattern_max_len =
IWLAGN_WOWLAN_MAX_PATTERN_LEN;
}
+#endif
if (iwlagn_mod_params.power_save)
hw->wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT;
prev parent reply other threads:[~2012-06-04 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 20:19 IWLWIFI should depend on SUSPEND Sebastian Kemper
2012-05-20 19:07 ` Johannes Berg
2012-05-30 13:29 ` Johannes Berg
2012-06-03 9:16 ` Sebastian Kemper
2012-06-03 15:02 ` Johannes Berg
[not found] ` <20120603164905.GA2056@wolfgang>
2012-06-03 18:33 ` Johannes Berg
2012-06-04 20:31 ` Sebastian Kemper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120604203124.GA2030@wolfgang \
--to=sebastian_ml@gmx.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).