From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Johannes Berg <johannes.berg@intel.com>,
Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] iwlwifi: turn on a lockdep assertion
Date: Sun, 10 Jun 2012 18:39:20 +0300 [thread overview]
Message-ID: <20120610153920.GP4400@mwanda> (raw)
In-Reply-To: <4FD4BC51.80407@bfs.de>
On Sun, Jun 10, 2012 at 05:25:05PM +0200, walter harms wrote:
>
>
> Am 10.06.2012 13:25, schrieb Dan Carpenter:
> > CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true and we
> > never check the assertion.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: enables the assertion even more than v1 (based on feedback from
> > Johannes Berg).
>
> The important part is CMD_SYNC -> CMD_ASYNC
Not really, no. I considered Johannes's version for my first patch
but I decided to be conservative because I didn't know the code well
enough to say what is safe.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-10 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 15:57 [patch] iwlwifi: turn on a lockdep assertion Dan Carpenter
2012-06-09 18:12 ` Johannes Berg
2012-06-09 19:07 ` Dan Carpenter
2012-06-10 11:25 ` [patch v2] " Dan Carpenter
2012-06-10 15:25 ` walter harms
2012-06-10 15:39 ` Dan Carpenter [this message]
2012-06-11 6:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120610153920.GP4400@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).