From: "John W. Linville" <linville@tuxdriver.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
"Linux Wireless List" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 5/5] brcmfmac: introduce checkdied debugfs functionality
Date: Mon, 11 Jun 2012 14:43:30 -0400 [thread overview]
Message-ID: <20120611184330.GC30086@tuxdriver.com> (raw)
In-Reply-To: <4FD42939.2020404@broadcom.com>
On Sun, Jun 10, 2012 at 06:57:29AM +0200, Arend van Spriel wrote:
> On 06/10/2012 04:13 AM, Gábor Stefanik wrote:
> > On Sat, Jun 9, 2012 at 10:51 PM, Arend van Spriel <arend@broadcom.com> wrote:
> >> The checkdied functionality provides useful information for analyzing
> >> firmware crashes. By exposing this information to a debugfs file users
> >> can easily provide its content in bug reports. The functionality is
> >> available only when CONFIG_BRCMDBG is selected.
> >>
> >> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
> >> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
> >> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> >> ---
> >> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 332 +++++++++++++++++++-
> >> 1 file changed, 331 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
> >> index a07fb01..5a33b42 100644
> >> --- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
> >> +++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
> >> @@ -31,6 +31,7 @@
> >> #include <linux/firmware.h>
> >> #include <linux/module.h>
> >> #include <linux/bcma/bcma.h>
> >> +#include <linux/debugfs.h>
> >> #include <asm/unaligned.h>
> >> #include <defs.h>
> >> #include <brcmu_wifi.h>
> >> @@ -48,6 +49,9 @@
> >>
> >> #define CBUF_LEN (128)
> >>
> >> +/* Device console log buffer state */
> >> +#define CONSOLE_BUFFER_MAX 2024
> >
> > Just out of curiosity; what is the significance of this number?
>
> It is used in the code fragment below. I have to admit the comment is
> not explaining its significance.
>
> >> + /* allocate buffer for console data */
> >> + if (console_size <= CONSOLE_BUFFER_MAX)
> >> + conbuf = kzalloc(console_size+1, GFP_ATOMIC);
> >> +
> >> + if (!conbuf)
> >> + return -ENOMEM;
>
> Probably would be better to use vmalloc() here or at least use
> GFP_KERNEL here.
>
> John, any recommendations?
vmalloc seems reasonable...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-06-11 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 20:51 [PATCH 0/5] brcm80211: small fixes and debugfs support in brcmfmac Arend van Spriel
2012-06-09 20:51 ` [PATCH 1/5] brcmsmac: remove brcms_set_hint() function Arend van Spriel
2012-06-09 20:51 ` [PATCH 2/5] brcmsmac: fix smatch warning found in ampdu.c Arend van Spriel
2012-06-09 20:51 ` [PATCH 3/5] brcmfmac: add debugfs helper functions Arend van Spriel
2012-06-09 20:51 ` [PATCH 4/5] brcmfmac: expose sdio internal counters in debugfs Arend van Spriel
2012-06-09 20:51 ` [PATCH 5/5] brcmfmac: introduce checkdied debugfs functionality Arend van Spriel
2012-06-10 2:13 ` Gábor Stefanik
2012-06-10 4:57 ` Arend van Spriel
2012-06-10 5:14 ` Gábor Stefanik
2012-06-13 13:29 ` Arend van Spriel
2012-06-11 18:43 ` John W. Linville [this message]
2012-06-13 13:35 ` Arend van Spriel
2012-06-13 17:50 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611184330.GC30086@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).