From: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: <linux-wireless@vger.kernel.org>, <linville@tuxdriver.com>,
<rodrigue@qca.qualcomm.com>,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [RFC] ath9k: raise aggregation limit to 64k for HT IBSS
Date: Fri, 22 Jun 2012 17:05:22 +0530 [thread overview]
Message-ID: <20120622113520.GA10283@vmraj-lnx.users.atheros.com> (raw)
In-Reply-To: <20010825.m5IpWLuaVf@bentobox>
On Fri, Jun 22, 2012 at 01:10:24PM +0200, Sven Eckelmann wrote:
> On Friday 22 June 2012 16:22:16 Rajkumar Manoharan wrote:
> > > + /* update ampdu factor/density, they may have changed. This may happen
> > > + * in HT IBSS when a beacon with HT-info is received after the station
> > > + * has already been added.
> > > + */
> > > + if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_HT) {
> > > + an->maxampdu = 1 << (IEEE80211_HT_MAX_AMPDU_FACTOR +
> > > + sta->ht_cap.ampdu_factor);
> > > + density = ath9k_parse_mpdudensity(sta->ht_cap.ampdu_density);
> > > + an->mpdudensity = density;
> > > + }
> > > +
> >
> > No need to declare local variable. ins't it?
>
> You want more than 80 chars per line or ugly/complex code...?
>
Never mind. keep the local variable.
-Rajkumar
prev parent reply other threads:[~2012-06-22 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 9:05 [RFC] ath9k: raise aggregation limit to 64k for HT IBSS Sven Eckelmann
2012-06-22 10:52 ` Rajkumar Manoharan
2012-06-22 11:10 ` Sven Eckelmann
2012-06-22 11:35 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622113520.GA10283@vmraj-lnx.users.atheros.com \
--to=rmanohar@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=siwu@hrz.tu-chemnitz.de \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox