* re: cfg80211: add 802.11ad (60gHz band) support
@ 2012-07-03 10:53 Dan Carpenter
2012-07-03 11:04 ` Johannes Berg
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2012-07-03 10:53 UTC (permalink / raw)
To: qca_vkondrat; +Cc: linux-wireless
Hello Vladimir Kondratiev,
The patch 3a0c52a6d82c: "cfg80211: add 802.11ad (60gHz band) support"
from Jul 2, 2012, leads to the following warning:
drivers/net/wireless/mac80211_hwsim.c:1841 init_mac80211_hwsim()
warn: buffer overflow 'data->bands' 2 <= 2
drivers/net/wireless/mac80211_hwsim.c
1839
1840 for (band = IEEE80211_BAND_2GHZ; band < IEEE80211_NUM_BANDS; band++) {
^^^^^^^^^^^^^^^^^^^
We raised IEEE80211_NUM_BANDS to 3.
1841 struct ieee80211_supported_band *sband = &data->bands[band];
^^^^^^^^^^^
This only has 2 elements still.
1842 switch (band) {
1843 case IEEE80211_BAND_2GHZ:
It causes a bogus dereference later.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: cfg80211: add 802.11ad (60gHz band) support
2012-07-03 10:53 cfg80211: add 802.11ad (60gHz band) support Dan Carpenter
@ 2012-07-03 11:04 ` Johannes Berg
2012-07-03 11:13 ` Vladimir Kondratiev
2012-07-03 11:32 ` Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Johannes Berg @ 2012-07-03 11:04 UTC (permalink / raw)
To: Dan Carpenter; +Cc: qca_vkondrat, linux-wireless
On Tue, 2012-07-03 at 13:53 +0300, Dan Carpenter wrote:
> Hello Vladimir Kondratiev,
>
> The patch 3a0c52a6d82c: "cfg80211: add 802.11ad (60gHz band) support"
> from Jul 2, 2012, leads to the following warning:
> drivers/net/wireless/mac80211_hwsim.c:1841 init_mac80211_hwsim()
> warn: buffer overflow 'data->bands' 2 <= 2
>
> drivers/net/wireless/mac80211_hwsim.c
> 1839
> 1840 for (band = IEEE80211_BAND_2GHZ; band < IEEE80211_NUM_BANDS; band++) {
> ^^^^^^^^^^^^^^^^^^^
> We raised IEEE80211_NUM_BANDS to 3.
>
> 1841 struct ieee80211_supported_band *sband = &data->bands[band];
> ^^^^^^^^^^^
> This only has 2 elements still.
>
> 1842 switch (band) {
> 1843 case IEEE80211_BAND_2GHZ:
>
> It causes a bogus dereference later.
Thanks Dan!
Is this one of your non-default tests? I think I ran smatch on this, but
it might be old. Anyway, I'll commit this fix:
http://p.sipsolutions.net/a1c40eea7e33541b.txt
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: cfg80211: add 802.11ad (60gHz band) support
2012-07-03 11:04 ` Johannes Berg
@ 2012-07-03 11:13 ` Vladimir Kondratiev
2012-07-03 11:34 ` Dan Carpenter
2012-07-03 11:32 ` Dan Carpenter
1 sibling, 1 reply; 6+ messages in thread
From: Vladimir Kondratiev @ 2012-07-03 11:13 UTC (permalink / raw)
To: Johannes Berg; +Cc: Dan Carpenter, qca_vkondrat, linux-wireless
On Tuesday, July 03, 2012 01:04:17 PM Johannes Berg wrote:
> Thanks Dan!
>
> Is this one of your non-default tests? I think I ran smatch on this, but
> it might be old. Anyway, I'll commit this fix:
>
> http://p.sipsolutions.net/a1c40eea7e33541b.txt
>
> johannes
Yes, exactly!
Was about to mail same patch.
What is the best method to catch such cases?
"make allmodconfig", or is there something better?
Tnanks, Vladimir
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cfg80211: add 802.11ad (60gHz band) support
2012-07-03 11:13 ` Vladimir Kondratiev
@ 2012-07-03 11:34 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-07-03 11:34 UTC (permalink / raw)
To: Vladimir Kondratiev; +Cc: Johannes Berg, qca_vkondrat, linux-wireless
On Tue, Jul 03, 2012 at 02:13:49PM +0300, Vladimir Kondratiev wrote:
> On Tuesday, July 03, 2012 01:04:17 PM Johannes Berg wrote:
> > Thanks Dan!
> >
> > Is this one of your non-default tests? I think I ran smatch on this, but
> > it might be old. Anyway, I'll commit this fix:
> >
> > http://p.sipsolutions.net/a1c40eea7e33541b.txt
> >
> > johannes
>
> Yes, exactly!
>
> Was about to mail same patch.
>
> What is the best method to catch such cases?
> "make allmodconfig", or is there something better?
This was a Smatch warning.
http://smatch.sourceforge.net/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cfg80211: add 802.11ad (60gHz band) support
2012-07-03 11:04 ` Johannes Berg
2012-07-03 11:13 ` Vladimir Kondratiev
@ 2012-07-03 11:32 ` Dan Carpenter
2012-07-03 11:42 ` Johannes Berg
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2012-07-03 11:32 UTC (permalink / raw)
To: Johannes Berg; +Cc: qca_vkondrat, linux-wireless
On Tue, Jul 03, 2012 at 01:04:17PM +0200, Johannes Berg wrote:
> On Tue, 2012-07-03 at 13:53 +0300, Dan Carpenter wrote:
> > Hello Vladimir Kondratiev,
> >
> > The patch 3a0c52a6d82c: "cfg80211: add 802.11ad (60gHz band) support"
> > from Jul 2, 2012, leads to the following warning:
> > drivers/net/wireless/mac80211_hwsim.c:1841 init_mac80211_hwsim()
> > warn: buffer overflow 'data->bands' 2 <= 2
> >
> > drivers/net/wireless/mac80211_hwsim.c
> > 1839
> > 1840 for (band = IEEE80211_BAND_2GHZ; band < IEEE80211_NUM_BANDS; band++) {
> > ^^^^^^^^^^^^^^^^^^^
> > We raised IEEE80211_NUM_BANDS to 3.
> >
> > 1841 struct ieee80211_supported_band *sband = &data->bands[band];
> > ^^^^^^^^^^^
> > This only has 2 elements still.
> >
> > 1842 switch (band) {
> > 1843 case IEEE80211_BAND_2GHZ:
> >
> > It causes a bogus dereference later.
>
> Thanks Dan!
>
> Is this one of your non-default tests? I think I ran smatch on this, but
> it might be old.
It should be on by default in the latest code. :)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: cfg80211: add 802.11ad (60gHz band) support
2012-07-03 11:32 ` Dan Carpenter
@ 2012-07-03 11:42 ` Johannes Berg
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Berg @ 2012-07-03 11:42 UTC (permalink / raw)
To: Dan Carpenter; +Cc: qca_vkondrat, linux-wireless
On Tue, 2012-07-03 at 14:32 +0300, Dan Carpenter wrote:
> > Thanks Dan!
> >
> > Is this one of your non-default tests? I think I ran smatch on this, but
> > it might be old.
>
> It should be on by default in the latest code. :)
I'll update anyway, but because of the huge number of warnings in all
the various wireless drives I didn't actually run it, I only ran it on
the mac80211 & cfg80211 code ... oops.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-03 11:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-03 10:53 cfg80211: add 802.11ad (60gHz band) support Dan Carpenter
2012-07-03 11:04 ` Johannes Berg
2012-07-03 11:13 ` Vladimir Kondratiev
2012-07-03 11:34 ` Dan Carpenter
2012-07-03 11:32 ` Dan Carpenter
2012-07-03 11:42 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).