From: Seth Forshee <seth.forshee@canonical.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] brcmsmac: fix brcms_c_regd_init() which crashed after 11ad patch
Date: Tue, 3 Jul 2012 08:26:08 -0500 [thread overview]
Message-ID: <20120703132608.GA5626@thinkpad-t410> (raw)
In-Reply-To: <1341321280-6136-1-git-send-email-arend@broadcom.com>
On Tue, Jul 03, 2012 at 03:14:40PM +0200, Arend van Spriel wrote:
> This patch fixes an OOPS in brcmsmac driver, which was introduced
> by the 11ad patch 'cfg80211: add 802.11ad (60gHz band) support'.
> The value IEEE80211_NUM_BANDS increased, which was used in the
> brcms_c_regd_init() function.
>
> Cc: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Seth Forshee <seth.forshee@canonical.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
Acked-by: Seth Forshee <seth.forshee@canonical.com>
Just one minor nit ...
> + if (band_idx == BAND_2G_INDEX) {
> + sband = wiphy->bands[IEEE80211_BAND_2GHZ];
> + } else {
> + sband = wiphy->bands[IEEE80211_BAND_5GHZ];
> + }
No need for braces here.
Cheers,
Seth
next prev parent reply other threads:[~2012-07-03 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 13:14 [PATCH] brcmsmac: fix brcms_c_regd_init() which crashed after 11ad patch Arend van Spriel
2012-07-03 13:26 ` Seth Forshee [this message]
2012-07-03 16:33 ` Arend van Spriel
-- strict thread matches above, loose matches on Subject: below --
2012-07-03 18:46 Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703132608.GA5626@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=arend@broadcom.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=qca_vkondrat@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).