From: "John W. Linville" <linville@tuxdriver.com>
To: thomas <thomas@net.t-labs.tu-berlin.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, nbd@openwrt.org,
brcm80211-dev-list@broadcom.com, pieterpg@broadcom.com,
gregkh@suse.de, frankyl@broadcom.com, arend@broadcom.com,
rvossen@broadcom.com, brudley@broadcom.com
Subject: Re: [PATCH v2] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon.
Date: Fri, 6 Jul 2012 15:37:33 -0400 [thread overview]
Message-ID: <20120706193733.GC1879@tuxdriver.com> (raw)
In-Reply-To: <4FEDC3F0.1000201@net.t-labs.tu-berlin.de>
On Fri, Jun 29, 2012 at 11:04:16AM -0400, thomas wrote:
> Johannes Berg schrieb:
>
> > On Fri, 2012-06-29 at 05:56 -0700, Thomas Huehn wrote:
> >> brcmsmac uses info->control.sta while doing ampdu aggregation. This patch
> >> changes the usage of the structure info->control.sta, as it is going to be
> >> removed soon from struct ieee80211_tx_info. This patch is a pre-requisit in
> >> order to add transmission power control (TPC) to the mac80211 subsystem.
> >>
> >> Suggested-by: Felix Fietkau <nbd@openwrt.org>
> >> Signed-off-by: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
> >> ---
> >> Change sequence of overwriting data. Thx to Johannes.
> >
> >
> >> @@ -665,7 +665,7 @@ brcms_c_sendampdu(struct ampdu_info *ampdu, struct brcms_txq_info *qi,
> >> u8 plcp0, plcp3, is40, sgi;
> >> struct ieee80211_sta *sta;
> >>
> >> - sta = tx_info->control.sta;
> >> + sta = tx_info->rate_driver_data[0];
> >
> > Are you sure it actually works now?
>
>
> From locking at the code, sta is never used after it gets overridden.
> The brcmsmac driver does not use the vif pointer at all. I asked Felix
> to double check as I do not have a Broadcom device over here.
>
> Bye Thomas
Any comments on this one from the Broadcom camp?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-07-06 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 12:56 [PATCH v2] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon Thomas Huehn
2012-06-29 13:06 ` Johannes Berg
2012-06-29 15:04 ` thomas
2012-07-06 19:37 ` John W. Linville [this message]
2012-07-08 19:41 ` Arend van Spriel
2012-07-08 19:47 ` Thomas Huehn
2012-07-09 13:47 ` Arend van Spriel
2012-07-09 13:53 ` Arend van Spriel
2012-07-09 22:11 ` Thomas Huehn
2012-07-10 8:34 ` Arend van Spriel
-- strict thread matches above, loose matches on Subject: below --
2012-07-09 14:15 Thomas Huehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706193733.GC1879@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=gregkh@suse.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=pieterpg@broadcom.com \
--cc=rvossen@broadcom.com \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).