From: Antonio Quartulli <ordex@autistici.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl/cfg/mac80211: add set_mcast_rate API
Date: Sun, 8 Jul 2012 12:07:13 +0200 [thread overview]
Message-ID: <20120708100713.GA4488@ritirata.org> (raw)
In-Reply-To: <1341741386.4987.5.camel@jlt3.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Sun, Jul 08, 2012 at 11:56:26AM +0200, Johannes Berg wrote:
> On Sun, 2012-07-08 at 11:31 +0200, Antonio Quartulli wrote:
>
> > +int cfg80211_set_mcast_rate(struct cfg80211_registered_device *rdev,
> > + struct net_device *dev,
> > + struct cfg80211_ibss_params *params)
>
> I'd say just inline the function into the nl80211.c handler itself, not
> much value in having it separate.
ok, will do.
>
>
> > + mcast_attr = nla_get_u32(info->attrs[NL80211_ATTR_MCAST_RATE]);
> > + if (info->attrs[NL80211_ATTR_MCAST_RATE] &&
>
> this is wrong
ops, you are right! I moved the nla_get_u32() at the line before to avoid having
a ugly statement, but I missed something :)
Thank you
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-07-08 10:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 9:31 [PATCH] nl/cfg/mac80211: add set_mcast_rate API Antonio Quartulli
2012-07-08 9:56 ` Johannes Berg
2012-07-08 10:07 ` Antonio Quartulli [this message]
2012-07-08 23:51 ` [PATCHv2] " Antonio Quartulli
2012-07-09 13:05 ` Johannes Berg
2012-07-09 13:12 ` Johannes Berg
2012-07-09 13:25 ` Antonio Quartulli
2012-07-09 13:18 ` Antonio Quartulli
2012-07-09 13:19 ` Johannes Berg
2012-07-09 13:27 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120708100713.GA4488@ritirata.org \
--to=ordex@autistici.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).