From: Antonio Quartulli <ordex@autistici.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl/cfg/mac80211: use BIT(x) instead of (1 << x)
Date: Mon, 9 Jul 2012 11:56:24 +0200 [thread overview]
Message-ID: <20120709095624.GC4488@ritirata.org> (raw)
In-Reply-To: <1341825724.4455.16.camel@jlt3.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
Hello Johannes,
On Mon, Jul 09, 2012 at 11:22:04AM +0200, Johannes Berg wrote:
>
...
>
> > rthdr->it_present |=
> > - cpu_to_le32(1 << IEEE80211_RADIOTAP_TSFT);
> > + cpu_to_le32(BIT(IEEE80211_RADIOTAP_TSFT));
>
> This makes sense, of course, it's actually doing bitwise operations.
>
> johannes
Thank you for your feedback.
At the beginning they confused me a BIT(), but now it's clear :)
I'll try to come up with a v2.
Thank you again.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-07-09 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 16:10 [PATCH] nl/cfg/mac80211: use BIT(x) instead of (1 << x) Antonio Quartulli
2012-07-09 9:22 ` Johannes Berg
2012-07-09 9:56 ` Antonio Quartulli [this message]
2012-07-09 15:56 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709095624.GC4488@ritirata.org \
--to=ordex@autistici.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).