From: "John W. Linville" <linville@tuxdriver.com>
To: Veli-Pekka Peltola <veli-pekka.peltola@bluegiga.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
Woody Hung <Woody.Hung@mediatek.com>
Subject: Re: [PATCH 1/2] rt2x00pci: small 3290 changes cleanup
Date: Wed, 11 Jul 2012 15:15:50 -0400 [thread overview]
Message-ID: <20120711191549.GD1937@tuxdriver.com> (raw)
In-Reply-To: <4FFBFCF0.6030506@bluegiga.com>
On Tue, Jul 10, 2012 at 12:59:12PM +0300, Veli-Pekka Peltola wrote:
> On 07/09/2012 03:41 PM, Stanislaw Gruszka wrote:
> >Fix indention and remove unnecessary brackets and compares.
>
> Hi,
>
> Otherwise looks ok but I have a one comment, see below.
>
> >Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> >---
> > drivers/net/wireless/rt2x00/rt2800pci.c | 11 +++++------
> > 1 files changed, 5 insertions(+), 6 deletions(-)
> >
> >diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
> >index dd43612..bf0e71e 100644
> >--- a/drivers/net/wireless/rt2x00/rt2800pci.c
> >+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
>
> <snip>
>
> >@@ -1022,9 +1022,8 @@ static int rt2800_enable_wlan_rt3290(struct rt2x00_dev *rt2x00dev)
> > rt2800_register_write(rt2x00dev, 0x58, 0x618);
> > udelay(REGISTER_BUSY_DELAY);
> > count++;
> >- } else {
> >+ } else
> > count = 0;
> >- }
>
> I have understood that Linux CodingStyle requires braces on all
> else/if branches if any of those have more than one statement. So I
> would not remove braces here.
I'll just drop that hunk...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2012-07-11 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 12:41 [PATCH 1/2] rt2x00pci: small 3290 changes cleanup Stanislaw Gruszka
2012-07-09 12:41 ` [PATCH 2/2] rt2800lib: merge same defines Stanislaw Gruszka
2012-07-10 6:34 ` Helmut Schaa
2012-07-10 6:33 ` [PATCH 1/2] rt2x00pci: small 3290 changes cleanup Helmut Schaa
2012-07-10 9:59 ` Veli-Pekka Peltola
2012-07-11 19:15 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711191549.GD1937@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Woody.Hung@mediatek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=users@rt2x00.serialmonkey.com \
--cc=veli-pekka.peltola@bluegiga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).