From: Pavel Roskin <proski@gnu.org>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath6kl-devel@qualcomm.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath6kl: fix incorrect use of IEEE80211_NUM_BANDS
Date: Thu, 12 Jul 2012 13:48:55 -0400 [thread overview]
Message-ID: <20120712134855.53d23fef@mj> (raw)
In-Reply-To: <20120712091311.9751.60082.stgit@localhost6.localdomain6>
On Thu, 12 Jul 2012 12:13:12 +0300
Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> + /* only check 2.4 and 5 GHz bands, skip the rest */
> + for (band = 0; band <= IEEE80211_BAND_5GHZ; band++) {
There is something inelegant here. The code is mixing an integer and
an enum. I'd rather go with one or those:
two enums:
for (band = IEEE80211_BAND_2GHZ; band <= IEEE80211_BAND_5GHZ; band++) {
or two integers:
for (band = 0; band <= ATH6KL_NUM_BANDS; band++) {
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2012-07-12 17:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 9:13 [PATCH] ath6kl: fix incorrect use of IEEE80211_NUM_BANDS Kalle Valo
2012-07-12 17:48 ` Pavel Roskin [this message]
2012-07-19 11:08 ` Kalle Valo
2012-07-19 21:11 ` Pavel Roskin
2012-07-20 6:18 ` Kalle Valo
2012-07-20 22:08 ` Pavel Roskin
2012-08-14 14:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712134855.53d23fef@mj \
--to=proski@gnu.org \
--cc=ath6kl-devel@qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).