From: Dan Carpenter <dan.carpenter@oracle.com>
To: chunkeey@googlemail.com
Cc: linux-wireless@vger.kernel.org
Subject: re: carl9170: improve unicast PS buffering
Date: Thu, 19 Jul 2012 14:36:28 +0300 [thread overview]
Message-ID: <20120719113628.GA32727@elgon.mountain> (raw)
Hello Christian Lamparter,
Sorry this is so old. I was going through some old Smatch warnings.
This is a semi-automatic email about new static checker warnings.
The patch caf1eae20668: "carl9170: improve unicast PS buffering" from
Apr 24, 2011, leads to the following Smatch complaint:
drivers/net/wireless/ath/carl9170/tx.c:1488 carl9170_op_tx()
error: we previously assumed 'sta' could be null (see line 1482)
drivers/net/wireless/ath/carl9170/tx.c
1481
1482 if (sta) {
^^^^^
New check.
1483 struct carl9170_sta_info *stai = (void *) sta->drv_priv;
1484 atomic_inc(&stai->pending_frames);
1485 }
1486
1487 if (info->flags & IEEE80211_TX_CTL_AMPDU) {
1488 run = carl9170_tx_ampdu_queue(ar, sta, skb);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Old dereference of "sta" inside the call to carl9170_tx_ampdu_queue().
1489 if (run)
1490 carl9170_tx_ampdu(ar);
Probably we can remove the check?
regards,
dan carpenter
next reply other threads:[~2012-07-19 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 11:36 Dan Carpenter [this message]
2012-07-19 12:29 ` carl9170: improve unicast PS buffering Christian Lamparter
2012-07-20 7:23 ` Dan Carpenter
2012-07-20 19:01 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719113628.GA32727@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).