linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Matt Chen <machen@suse.com>
Cc: kevin.chou@mediatek.com, linux-wireless@vger.kernel.org,
	users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH] rt2x00 : fix rt3290 resuming failed.
Date: Mon, 23 Jul 2012 13:24:22 +0200	[thread overview]
Message-ID: <20120723112359.GA2567@redhat.com> (raw)
In-Reply-To: <CALx5=V8Sz_CiqQvX-N1hscmpYa7GTO2YfukS8BJc1YChLFmd5Q@mail.gmail.com>

Hi

On Mon, Jul 23, 2012 at 03:01:08PM +0800, Matt Chen wrote:
> >> +
> >> +                     rt2800_register_write(rt2x00dev, 0x58, 0x018);
> >> +                     udelay(REGISTER_BUSY_DELAY);
> >> +                     rt2800_register_write(rt2x00dev, 0x58, 0x418);
> >> +                     udelay(REGISTER_BUSY_DELAY);
> >> +                     rt2800_register_write(rt2x00dev, 0x58, 0x618);
> > We really like to know what those black magic numbers mean.
> I have no idea, Ralink gave it to me for the fixing.

So perhaps patch should be posted by Ralink developer, who can fix that
accordingly?

Also it's clear now that you are not the author of the patch. Would be
good to indicate true author of the patch by adding "From:" and
"Signed-off-by:" lines.

Thanks
Stanislaw

  reply	other threads:[~2012-07-23 11:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19  3:18 [rt2x00-users] [PATCH] rt2x00 : fix rt3290 resuming failed Chen, Chien-Chia
2012-07-19 11:51 ` Helmut Schaa
2012-07-19 11:57 ` Ivo Van Doorn
2012-07-19 14:54 ` Stanislaw Gruszka
2012-07-23  7:01   ` Matt Chen
2012-07-23 11:24     ` Stanislaw Gruszka [this message]
2012-07-23 12:35       ` Matt Chen
2012-07-24  6:24       ` Matt Chen
2012-07-24  7:21         ` Kevin Chou (周庭昱)
  -- strict thread matches above, loose matches on Subject: below --
2012-07-27  7:03 Chen, Chien-Chia
2012-07-27 10:18 ` Stanislaw Gruszka
2012-07-27 14:22   ` Matt Chen
2012-07-30  7:33     ` Stanislaw Gruszka
2012-07-30  8:09       ` Matt Chen
2012-07-18  8:40 [rt2x00-users][PATCH] " Chen, Chien-Chia
2012-07-18 11:21 ` [rt2x00-users] [PATCH] " Henning Heinold
2012-07-18 14:29   ` Matt Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120723112359.GA2567@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=kevin.chou@mediatek.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=machen@suse.com \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).