From: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
"John W. Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>, <users@rt2x00.serialmonkey.com>,
Hong Wu <Hong.Wu@dspg.com>
Subject: Re: [PATCH] wireless: reg: restore previous behaviour of chan->max_power calculations
Date: Tue, 24 Jul 2012 12:28:45 -0700 [thread overview]
Message-ID: <20120724192845.GB31108@tux> (raw)
In-Reply-To: <1343141586.4415.40.camel@jlt3.sipsolutions.net>
On Tue, Jul 24, 2012 at 04:53:06PM +0200, Johannes Berg wrote:
> On Tue, 2012-07-24 at 08:35 +0200, Stanislaw Gruszka wrote:
> > commit eccc068e8e84c8fe997115629925e0422a98e4de
> > Author: Hong Wu <Hong.Wu@dspg.com>
> > Date: Wed Jan 11 20:33:39 2012 +0200
> >
> > wireless: Save original maximum regulatory transmission power for the calucation of the local maximum transmit pow
> >
> > changed the way we calculate chan->max_power as min(chan->max_power,
> > chan->max_reg_power). That broke rt2x00 (and perhaps some other
> > drivers) that do not set chan->max_power. It is not so easy to fix this
> > problem correctly in rt2x00.
> >
> > According to commit eccc068e8 changelog, change claim only to save
> > maximum regulatory power - changing setting of chan->max_power was side
> > effect. This patch restore previous calculations of chan->max_power and
> > do not touch chan->max_reg_power.
>
> Applied, but I'll wait for Luis's comments before I push it out.
Acked-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
Makes sense, thanks for catching this.
Luis
prev parent reply other threads:[~2012-07-24 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 6:35 [PATCH] wireless: reg: restore previous behaviour of chan->max_power calculations Stanislaw Gruszka
2012-07-24 14:53 ` Johannes Berg
2012-07-24 19:28 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724192845.GB31108@tux \
--to=rodrigue@qca.qualcomm.com \
--cc=Hong.Wu@dspg.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).