* bcma_bus_scan/bcma_bus_scan_early: missing iounmap
@ 2012-07-25 11:05 Fengguang Wu
2012-07-26 15:48 ` Hauke Mehrtens
0 siblings, 1 reply; 2+ messages in thread
From: Fengguang Wu @ 2012-07-25 11:05 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: Rafał Miłecki, LKML, linux-wireless
Hi Hauke,
The coccinelle static checker emits these warnings:
drivers/bcma/scan.c:466:3-9: ERROR: missing iounmap; ioremap on line 451 and execution via conditional on line 465
drivers/bcma/scan.c:540:3-9: ERROR: missing iounmap; ioremap on line 515 and execution via conditional on line 539
It seems we need to change the return statements to goto/break statements.
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: bcma_bus_scan/bcma_bus_scan_early: missing iounmap
2012-07-25 11:05 bcma_bus_scan/bcma_bus_scan_early: missing iounmap Fengguang Wu
@ 2012-07-26 15:48 ` Hauke Mehrtens
0 siblings, 0 replies; 2+ messages in thread
From: Hauke Mehrtens @ 2012-07-26 15:48 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Rafał Miłecki, LKML, linux-wireless
On 07/25/2012 01:05 PM, Fengguang Wu wrote:
> Hi Hauke,
>
> The coccinelle static checker emits these warnings:
>
> drivers/bcma/scan.c:466:3-9: ERROR: missing iounmap; ioremap on line 451 and execution via conditional on line 465
> drivers/bcma/scan.c:540:3-9: ERROR: missing iounmap; ioremap on line 515 and execution via conditional on line 539
>
> It seems we need to change the return statements to goto/break statements.
>
> Thanks,
> Fengguang
Hi Fengguang,
Thanks for the hint on this problem, I just sent a patch to fix this to
John Linville and the linux-wireless mailing list.
Hauke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-26 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-25 11:05 bcma_bus_scan/bcma_bus_scan_early: missing iounmap Fengguang Wu
2012-07-26 15:48 ` Hauke Mehrtens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).