Re: [rt2x00-users] [PATCH] rt2x00 : fix rt3290 resuming failed.

[Stanislaw Gruszka <sgruszka@redhat.com>]

Hi

On Fri, Jul 27, 2012 at 10:22:44PM +0800, Matt Chen wrote:
> 2012/7/27 Stanislaw Gruszka <sgruszka@redhat.com>:
> > On Fri, Jul 27, 2012 at 03:03:54PM +0800, Chen, Chien-Chia wrote:
> >> This patch is going to fix the resuming failed from S3/S4
> >> for rt3290 chip.
> >>
> >> Signed-off-by: Chen, Chien-Chia <machen@suse.com>
> >> CC-by: Kevin Chou <kevin.chou@mediatek.com>
> >
> > Could you please post patches that compile? Also you did not set true
> Compile ? you mean the *.o files and *.ko ?

Patch does not compile:

drivers/net/wireless/rt2x00/rt2800lib.c:5163: error: static declaration of ‘rt2800_enable_wlan_rt3290’ follows non-static declaration
drivers/net/wireless/rt2x00/rt2800lib.h:212: note: previous declaration of ‘rt2800_enable_wlan_rt3290’ was here
make[1]: *** [drivers/net/wireless/rt2x00/rt2800lib.o] Error 1
make: *** [drivers/net/wireless/rt2x00/] Error 2

How did you tested the patch ?

> > author of the patch. Additionally, since repost that patch with changes,
> > you should mark version of the patch and provide information about
> > changes, like for example here:
> Hmm....I added the Author: Woody Hung <Woody.Hung@mediatek.com> but
> don't know why it doesn't show here. :(

So fix that. Post patch to yourself first to see if setting works.

Stanislaw