From: Josh Boyer <jwboyer@redhat.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
Arend van Spriel <arend@broadcom.com>,
Brett Rudley <brudley@broadcom.com>,
Roland Vossen <rvossen@broadcom.com>,
brcm80211-dev-list@broadcom.com
Subject: Re: [PATCH 0/2] Fix lockdep warning in brcmsmac
Date: Wed, 1 Aug 2012 20:23:54 -0400 [thread overview]
Message-ID: <20120802002353.GD1785@zod.bos.redhat.com> (raw)
In-Reply-To: <1343854723-21987-1-git-send-email-seth.forshee@canonical.com>
On Wed, Aug 01, 2012 at 03:58:41PM -0500, Seth Forshee wrote:
> As reported by Josh Boyer, brcmsmac is producing lockdep warnings by
> calling freq_reg_info() without holding cfg80211_lock. Currently
> freq_reg_info() is the only way for a wireless driver to tell whether
> OFDM is allowed on the current channel, but cfg80211_lock is outside the
> scope of the wireless drivers.
>
> Since other regulatory restrictions are communicated in the channel
> definition, it makes sense to do the same for OFDM. These patches add a
> new flag, IEEE80211_CHAN_NO_OFDM, which is set by regulatory to
> indicated OFDM operation is prohibited. brcmsmac is modifified to use
> this flag instead of consuming the regulatory data directly.
>
> Thanks,
> Seth
>
>
> Seth Forshee (2):
> cfg80211: add channel flag to restrict OFDM
> brcmsmac: use channel flags to restrict OFDM
I would love to test these, but at the moment I can't. Oddly, the very
same machine I hit the problem with originally is no longer presenting
any devices on the bcma bus. The driver is loaded, brcmsmac is loaded,
but neither output the devices that showed up in my original email.
This is with both the kernel I originally reported the problem with, and
other kernels. Nothing shows up for the BCM4313 in lspci either.
I did power it off and then back on today after I hit the original
problem, but I'd expect the hardware in the box to still show up on a
power on... Is there some specific module load order, or something
else I can do to try and get the device to show up?
I did build a kernel with your patches applied, so at least I know they
build. If I can get this machine to probe the chip again, I'll be happy
to test.
At the moment, I'm just very confused and slightly afraid it's going to
just refuse to work at all.
josh
next prev parent reply other threads:[~2012-08-02 0:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 20:58 [PATCH 0/2] Fix lockdep warning in brcmsmac Seth Forshee
2012-08-01 20:58 ` [PATCH 1/2] cfg80211: add channel flag to prohibit OFDM operation Seth Forshee
2012-08-01 21:20 ` Luis R. Rodriguez
2012-08-02 6:24 ` Johannes Berg
2012-08-02 13:04 ` Seth Forshee
2012-08-02 13:31 ` Johannes Berg
2012-08-01 20:58 ` [PATCH 2/2] brcmsmac: use channel flags to restrict OFDM Seth Forshee
2012-08-02 0:23 ` Josh Boyer [this message]
2012-08-02 1:53 ` [PATCH 0/2] Fix lockdep warning in brcmsmac Seth Forshee
2012-08-02 12:02 ` Josh Boyer
2012-08-02 12:51 ` Josh Boyer
2012-08-02 13:42 ` Arend van Spriel
2012-08-02 13:45 ` Josh Boyer
2012-08-02 14:00 ` Arend van Spriel
2012-08-02 14:45 ` Josh Boyer
2012-08-02 14:49 ` Josh Boyer
2012-08-02 13:44 ` Hauke Mehrtens
2012-08-02 13:54 ` Josh Boyer
2012-08-02 11:01 ` Arend van Spriel
2012-08-02 11:39 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802002353.GD1785@zod.bos.redhat.com \
--to=jwboyer@redhat.com \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=rvossen@broadcom.com \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).