* [patch] wireless: at76c50x: signedness bug in at76_dfu_get_state()
@ 2012-08-09 6:57 Dan Carpenter
2012-08-09 21:18 ` Pavel Roskin
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-08-09 6:57 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, kernel-janitors
This return holds the number of bytes transfered (1 byte) or a negative
error code. The type should be int instead of u8.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c
index efc162e..88b8d64 100644
--- a/drivers/net/wireless/at76c50x-usb.c
+++ b/drivers/net/wireless/at76c50x-usb.c
@@ -342,7 +342,7 @@ static int at76_dfu_get_status(struct usb_device *udev,
return ret;
}
-static u8 at76_dfu_get_state(struct usb_device *udev, u8 *state)
+static int at76_dfu_get_state(struct usb_device *udev, u8 *state)
{
int ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] wireless: at76c50x: signedness bug in at76_dfu_get_state()
2012-08-09 6:57 [patch] wireless: at76c50x: signedness bug in at76_dfu_get_state() Dan Carpenter
@ 2012-08-09 21:18 ` Pavel Roskin
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Roskin @ 2012-08-09 21:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: John W. Linville, linux-wireless, kernel-janitors
On Thu, 9 Aug 2012 09:57:30 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This return holds the number of bytes transfered (1 byte) or a
> negative error code. The type should be int instead of u8.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pavel Roskin <proski@gnu.org>
Nice catch, thanks!
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-09 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-09 6:57 [patch] wireless: at76c50x: signedness bug in at76_dfu_get_state() Dan Carpenter
2012-08-09 21:18 ` Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).