From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ocean.emcraft.com ([213.221.7.182]:49855 "EHLO ocean.emcraft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359Ab2HTLkX (ORCPT ); Mon, 20 Aug 2012 07:40:23 -0400 Date: Mon, 20 Aug 2012 15:40:16 +0400 From: Sergei Poselenov To: "Luis R. Rodriguez" Cc: Ivo Van Doorn , Gertjan van Wingerde , Helmut Schaa , backports@vger.kernel.org, "Luis R. Rodriguez" , lf_driver_backport@lists.linux-foundation.org, linux-wireless@vger.kernel.org, linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] compat-wireless:rt2800usb: Added rx packet length validity check Message-ID: <20120820154016.3f0a587a@emcraft.com> (sfid-20120820_134032_019553_613BBBF4) In-Reply-To: References: <20120817212007.6a77cbb8@emcraft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello Luis, Thanks for the feedback. One simple question below. On Mon, 20 Aug 2012 11:35:06 +0500 "Luis R. Rodriguez" wrote: > On Fri, Aug 17, 2012 at 9:20 PM, Sergei Poselenov > wrote: > > > > On our system (ARM Cortex-M3 SOC running linux-2.6.33 with > > compat-wireless-3.4-rc3-1 modules configured for rt2x00) frequent > > crashes were observed in rt2800usb module because of the invalid > > length of the received packet (3392, 46920...). This patch adds > > the sanity check on the packet legth. In case of the bad length, > > mark the packet as with CRC error. > > Nice find! However this is a *real* patch that must go upstream, so > you should submit it to the rt2800usb maintainers and also mark the > patch as a stable fix. You mark the patch as a stable fix by appending > at the bottom of the commit log message: Cc: stable@vger.kernel.org. > For example: > Before I did something stupid with my patch, here is what I'm going to do to make it reviewed in upsteam: - Reapply and retest on compat-wireless-3.5.1-1-snpc.tar.bz2 - According to the http://linuxwireless.org/en/developers/maintainers send the patch to M: Ivo van Doorn M: Gertjan van Wingerde M: Helmut Schaa and CC to linux-wireless@vger.kernel.org - Add the "Cc: stable@vger.kernel.org" before my "Signed-off-by" tag, as suggested in the example below. Is that correct? Thanks is advance. After I will submit it to the mainline, I will try to provide the patch to the linux-next-pending. Regards, Sergei Poselenov, Emcraft Systems > commit e19f15ac6437624b6214b2f0ec0d69fb7eb205fa > Author: Rajkumar Manoharan > Date: Thu Aug 9 12:37:26 2012 +0530 > > ath9k: stop btcoex on device suspend > > During suspend, the device will be moved to FULLSLEEP state. > As btcoex is never been stopped, the btcoex timer is running > and tries to access hw on fullsleep state. Fix that. > > Cc: stable@vger.kernel.org > Signed-off-by: Rajkumar Manoharan > Signed-off-by: John W. Linville > > Once you submit if you want it merged into a stable compat-wireless > release even before Greg Kroah-Hartman can apply it and make a new > 3.4.10 release (by the time you submit maybe 3.4.11 maybe) you can > send the patch to be applied to the driver in compat-wirelss by > submitting it to be part of the linux-next-pending/ directory. In > there are patches that are at least posted publicly. The format of the > patch there is to be in a full patch. If you have doubts check out the > compat-wireless-3.5.1-1-snpc.tar.bz2 release which has patches in all > of these directories: > > * pending-stable/ > * linux-next-pending/ > * linux-next-cherry-picks/ > * crap/ > > At this point you may also want to consider upgrading to > compat-wireless-3.5.1-1-snpc.tar.bz2. I should note that to send > patches for the 3.4 stable release of compat-wireless you should use > the linux-3.4.y branch. The same applies to the 3.5 release, you'd use > the linux-3.5.y branch. Except for patches for files in the above > directories I also require all patches merged into the stable branches > to be in the master branch first -- this follows the kernel's on > policy on stable releases. > > The compat-wireless project is also now renamed to "compat-drivers" > and we have a new mailing list and home page for the project. New > releases based under the new name will start as of the v3.7 releases. > For more details please see: > > https://backports.wiki.kernel.org > > Please have a read here with regards for documentation of the > additional patches for compat-drivers. > > https://backports.wiki.kernel.org/index.php/Documentation/compat-drivers/additional-patches > > Luis