From: Dan Carpenter <dan.carpenter@oracle.com>
To: johannes.berg@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: re: mac80211: support P2P Device abstraction
Date: Tue, 4 Sep 2012 19:13:19 +0300 [thread overview]
Message-ID: <20120904161319.GA11494@elgon.mountain> (raw)
Hello Johannes Berg,
This is a semi-automatic email about new static checker warnings.
The patch f142c6b906da: "mac80211: support P2P Device abstraction"
from Jun 18, 2012, leads to the following Smatch complaint:
net/mac80211/iface.c:1168 ieee80211_setup_sdata()
error: we previously assumed 'sdata->dev' could be null (see line 1134)
net/mac80211/iface.c
1133 /* only monitor/p2p-device differ */
1134 if (sdata->dev) {
^^^^^^^^^^
New test.
1135 sdata->dev->netdev_ops = &ieee80211_dataif_ops;
1136 sdata->dev->type = ARPHRD_ETHER;
1137 }
[snip]
1167 case NL80211_IFTYPE_MONITOR:
1168 sdata->dev->type = ARPHRD_IEEE80211_RADIOTAP;
^^^^^^^^^^^^
Old dereference.
1169 sdata->dev->netdev_ops = &ieee80211_monitorif_ops;
1170 sdata->u.mntr_flags = MONITOR_FLAG_CONTROL |
regards,
dan carpenter
next reply other threads:[~2012-09-04 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 16:13 Dan Carpenter [this message]
2012-09-04 16:18 ` mac80211: support P2P Device abstraction Johannes Berg
2012-09-04 17:20 ` Dan Carpenter
2012-09-04 17:27 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904161319.GA11494@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).