From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>,
linux-wireless@vger.kernel.org, jirislaby@gmail.com,
mickflemm@gmail.com, mcgrof@qca.qualcomm.com,
ath5k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath5k: add support of HW encryption in management frames
Date: Wed, 5 Sep 2012 10:11:22 +0300 [thread overview]
Message-ID: <20120905071122.GA3629@w1.fi> (raw)
In-Reply-To: <1346758521.3737.28.camel@jlt4.sipsolutions.net>
On Tue, Sep 04, 2012 at 01:35:21PM +0200, Johannes Berg wrote:
> I would guess that hardware *decryption* is faulty, maybe only one
> action frame needs to be correct and so if one of them is nohwcrypt=1 it
> still works?
Yes, I was assuming that receiving robust unicast management frames
would fail with ath5k. This is exactly the reason why I adding
IEEE80211_HW_MFP_CAPABLE conditionally in ath9k only for the hardware
revisions that support the new CCMP rules.
It should be possible to work around this if someone really cares, but
that require the driver to re-encrypt the incorrectly decrypted frame
(i.e., using the pre-802.11w rules on CCMP exactly in the way the
hardware did it) and then pass that end result for masc80211 to decrypt
it correctly. I considered doing that for a while, but did not find
enough justification to work with that.
--
Jouni Malinen PGP id EFC895FA
prev parent reply other threads:[~2012-09-05 7:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 9:34 [PATCH] ath5k: add support of HW encryption in management frames Chun-Yeow Yeoh
2012-08-31 6:58 ` Adrian Chadd
2012-08-31 15:24 ` Yeoh Chun-Yeow
2012-09-03 19:24 ` Adrian Chadd
2012-09-04 1:03 ` Yeoh Chun-Yeow
2012-09-04 8:11 ` Johannes Berg
2012-09-04 9:28 ` Yeoh Chun-Yeow
2012-09-04 9:31 ` Johannes Berg
2012-09-04 10:22 ` Jouni Malinen
2012-09-04 11:21 ` Yeoh Chun-Yeow
2012-09-04 11:25 ` Yeoh Chun-Yeow
2012-09-04 11:35 ` Johannes Berg
2012-09-04 16:41 ` Yeoh Chun-Yeow
2012-09-04 16:54 ` Johannes Berg
2012-09-05 6:52 ` Yeoh Chun-Yeow
2012-09-04 16:55 ` Christian Lamparter
2012-09-04 16:57 ` Johannes Berg
2012-09-05 7:16 ` Jouni Malinen
2012-09-05 7:31 ` Yeoh Chun-Yeow
2012-09-05 8:03 ` Jouni Malinen
2012-09-07 3:51 ` Yeoh Chun-Yeow
2012-09-09 1:47 ` Adrian Chadd
2012-09-10 13:13 ` Kalle Valo
2012-09-10 15:11 ` Yeoh Chun-Yeow
2012-09-11 6:46 ` Nick Kossifidis
2012-09-11 9:42 ` Yeoh Chun-Yeow
2012-09-11 15:05 ` Nick Kossifidis
2012-09-11 15:51 ` Yeoh Chun-Yeow
2012-09-11 16:06 ` Nick Kossifidis
2012-09-11 16:07 ` Nick Kossifidis
2012-09-11 16:20 ` Yeoh Chun-Yeow
2012-09-11 16:30 ` Adrian Chadd
2012-09-11 16:36 ` Nick Kossifidis
2012-09-11 16:39 ` Johannes Berg
2012-09-11 17:31 ` Christian Lamparter
2012-09-11 17:48 ` Nick Kossifidis
2012-09-05 7:11 ` Jouni Malinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905071122.GA3629@w1.fi \
--to=j@w1.fi \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=mickflemm@gmail.com \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).