From: Samuel Ortiz <sameo@linux.intel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
yongjun_wei@trendmicro.com.cn, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] NFC: move the dereference below the NULL test
Date: Fri, 7 Sep 2012 19:05:22 +0200 [thread overview]
Message-ID: <20120907170522.GG3647@sortiz-mobl> (raw)
In-Reply-To: <CAPgLHd8yH37C=mRWinWM4FGQaWTvH0r69PFEgJCNZL2DdZAS1A@mail.gmail.com>
Hi Wei,
On Fri, Sep 07, 2012 at 02:51:47PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The dereference should be moved below the NULL test.
>
> spatch with a semantic match is used to found this.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/nfc/nfcwilink.c | 4 ++--
> drivers/nfc/pn544_hci.c | 3 ++-
> drivers/nfc/pn544.c | 3 ++-
> 3 files changed, 6 insertions(+), 4 deletions(-)
Those are correct fixes but could you please split the nfcwilink and pn544_hci
fixes into 2 patches. Also, the pn544 driver is going to be removed so no need
to fix it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-09-07 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 6:51 [PATCH] NFC: move the dereference below the NULL test Wei Yongjun
2012-09-07 17:05 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907170522.GG3647@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-wireless@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).