From: Samuel Ortiz <sameo@linux.intel.com>
To: Eric Lapuyade <eric.lapuyade@linux.intel.com>
Cc: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>,
eric.lapuyade@intel.com, linux-wireless@vger.kernel.org,
linux-nfc@lists.01.org
Subject: Re: [linux-nfc] [PATCH v2 1/2] NFC: Remove crc generation from shdlc layer
Date: Fri, 7 Sep 2012 19:15:53 +0200 [thread overview]
Message-ID: <20120907171553.GH4128@sortiz-mobl> (raw)
In-Reply-To: <5049E874.8010306@linux.intel.com>
Hi Waldemar, Eric.
On Fri, Sep 07, 2012 at 02:28:36PM +0200, Eric Lapuyade wrote:
> Hi Waldek,
>
> On 09/07/2012 11:08 AM, Waldemar Rymarkiewicz wrote:
> > Checksum is specific for a chip spcification and it varies
> > (in size and type) between different hardware. It should be
> > handled in the driver then.
> >
> > Moreover, shdlc spec doesn't mention crc as a part of the frame.
> >
> > Update pn544_hci driver as well.
> >
> > Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
> > ---
>
> I have tested this on top of Samuel's nfc-next and it works as expected.
> Thank you.
>
> Acked-by: Eric Lapuyade <eric.lapuyade@intel.com>
Patch applied, thanks guys.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-09-07 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 9:08 [PATCH v2 1/2] NFC: Remove crc generation from shdlc layer Waldemar Rymarkiewicz
2012-09-07 9:08 ` [PATCH v2 2/2] NFC: Correct outgoing frame before requeueing Waldemar Rymarkiewicz
2012-09-07 12:28 ` [linux-nfc] " Eric Lapuyade
2012-09-07 17:16 ` Samuel Ortiz
2012-09-07 12:28 ` [linux-nfc] [PATCH v2 1/2] NFC: Remove crc generation from shdlc layer Eric Lapuyade
2012-09-07 17:15 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907171553.GH4128@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=eric.lapuyade@intel.com \
--cc=eric.lapuyade@linux.intel.com \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=waldemar.rymarkiewicz@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).