Re: [PATCH v2] p54: connect to 11w protected networks

[Christian Lamparter <chunkeey@googlemail.com>]

On Friday 07 September 2012 17:55:42 Johannes Berg wrote:
> On Fri, 2012-09-07 at 17:47 +0200, Christian Lamparter wrote:
> > On Friday 07 September 2012 14:17:14 Johannes Berg wrote:
> > > On Tue, 2012-09-04 at 16:54 +0200, Johannes Berg wrote:
> > >
> > > If you want this for your driver, I'll commit this:
> > > 
> > > http://p.sipsolutions.net/ea2e3dbe980f5db8.txt
> > 
> > Won't this totally disable the crypto offload
> > capabilities in AP mode?
> 
> Yes, though we could add an nl80211 attribute that
> allows hostapd to tell us, and then if it did tell
> us we could know and do the right thing here.

Well, if we want to do the right thing here, then I
guess we should go for another alternative: a rxkey
manager of some sorts. So, we delete keys from the
firmware context once MFP comes into the game.

This method also has another advantage that with
a proper manager we can use the key usage statistics
and upload only the most-used keys into the firmware
context (most/all? p54 firmwares have usually 4-8 key
slots in total, which is not always enough).
 
> > I sort of prefer the nohwcrypt switch as it won't
> > interfere with running user setups as much (so we
> > don't burden systems like that weird telekom
> > streamin-box (Vision S100 - it's name I think)
> > that came with a p54pci minipci card and are
> > now used for different purposes by some.
> 
> I guess it would make sense then to give hostapd the ability to tell us?
> 
> It's up to you. I don't need 11w, nor do I have p54 hardware, nor does
> it matter much to me ... :)
Let's save that task for a rainy day :-D.

Regards,
	Chr