* [PATCH v2] NFC: nfcwilink: move the dereference below the NULL test
@ 2012-09-08 1:53 Wei Yongjun
2012-09-19 0:25 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-08 1:53 UTC (permalink / raw)
To: lauro.venancio, aloisio.almeida, sameo; +Cc: yongjun_wei, linux-wireless
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/nfc/nfcwilink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nfc/nfcwilink.c b/drivers/nfc/nfcwilink.c
index e7fd493..1a47190 100644
--- a/drivers/nfc/nfcwilink.c
+++ b/drivers/nfc/nfcwilink.c
@@ -352,8 +352,6 @@ static long nfcwilink_receive(void *priv_data, struct sk_buff *skb)
struct nfcwilink *drv = priv_data;
int rc;
- nfc_dev_dbg(&drv->pdev->dev, "receive entry, len %d", skb->len);
-
if (!skb)
return -EFAULT;
@@ -362,6 +360,8 @@ static long nfcwilink_receive(void *priv_data, struct sk_buff *skb)
return -EFAULT;
}
+ nfc_dev_dbg(&drv->pdev->dev, "receive entry, len %d", skb->len);
+
/* strip the ST header
(apart for the chnl byte, which is not received in the hdr) */
skb_pull(skb, (NFCWILINK_HDR_LEN-1));
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] NFC: nfcwilink: move the dereference below the NULL test
2012-09-08 1:53 [PATCH v2] NFC: nfcwilink: move the dereference below the NULL test Wei Yongjun
@ 2012-09-19 0:25 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2012-09-19 0:25 UTC (permalink / raw)
To: Wei Yongjun; +Cc: lauro.venancio, aloisio.almeida, yongjun_wei, linux-wireless
Hi Wei,
On Sat, Sep 08, 2012 at 09:53:22AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The dereference should be moved below the NULL test.
>
> spatch with a semantic match is used to found this.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/nfc/nfcwilink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-19 0:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-08 1:53 [PATCH v2] NFC: nfcwilink: move the dereference below the NULL test Wei Yongjun
2012-09-19 0:25 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).