linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] RFC ath5k: missing break
@ 2012-09-26 17:02 Alan Cox
  0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2012-09-26 17:02 UTC (permalink / raw)
  To: linux-wireless

From: Alan Cox <alan@linux.intel.com>

This code seems to make no sense otherwise for 5MHz mode as it always
recomputes the values in the fall through.

[ath5k_hw_set_opmode looks suspicious too btw]

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 drivers/net/wireless/ath/ath5k/phy.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 01c90ed..ab363f3 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1975,11 +1975,13 @@ ath5k_hw_set_spur_mitigation_filter(struct ath5k_hw *ah,
 			spur_delta_phase = (spur_offset << 18) / 25;
 			spur_freq_sigma_delta = (spur_delta_phase >> 10);
 			symbol_width = AR5K_SPUR_SYMBOL_WIDTH_BASE_100Hz / 2;
+			break;
 		case AR5K_BWMODE_5MHZ:
 			/* Both sample_freq and chip_freq are 10MHz (?) */
 			spur_delta_phase = (spur_offset << 19) / 25;
 			spur_freq_sigma_delta = (spur_delta_phase >> 10);
 			symbol_width = AR5K_SPUR_SYMBOL_WIDTH_BASE_100Hz / 4;
+			break;
 		default:
 			if (channel->band == IEEE80211_BAND_5GHZ) {
 				/* Both sample_freq and chip_freq are 40MHz */


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-09-26 16:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-26 17:02 [PATCH] RFC ath5k: missing break Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).