linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66.
@ 2012-10-03 23:20 Daniel Golle
  2012-10-04  9:37 ` Gertjan van Wingerde
  2012-10-04 18:58 ` Ivo Van Doorn
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Golle @ 2012-10-03 23:20 UTC (permalink / raw)
  To: linux-wireless; +Cc: linville

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

This should be register 66 instead of 62.
(probably happened by copy&past'ing from the lines below)

Signed-off-by: Daniel Golle <dgolle@allnet.de>

---
 drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 540c94f..01dc889 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2252,9 +2252,9 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
 	 */
 	if (rt2x00_rt(rt2x00dev, RT3352)) {
 		rt2800_bbp_write(rt2x00dev, 27, 0x0);
-		rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
+		rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
 		rt2800_bbp_write(rt2x00dev, 27, 0x20);
-		rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
+		rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
 	} else {
 		rt2800_bbp_write(rt2x00dev, 62, 0x37 - rt2x00dev->lna_gain);
 		rt2800_bbp_write(rt2x00dev, 63, 0x37 - rt2x00dev->lna_gain);
-- 
1.7.12.2


[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66.
  2012-10-03 23:20 [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66 Daniel Golle
@ 2012-10-04  9:37 ` Gertjan van Wingerde
  2012-10-04 18:58 ` Ivo Van Doorn
  1 sibling, 0 replies; 3+ messages in thread
From: Gertjan van Wingerde @ 2012-10-04  9:37 UTC (permalink / raw)
  To: Daniel Golle; +Cc: linux-wireless, linville

On Thu, Oct 4, 2012 at 1:20 AM, Daniel Golle <dgolle@allnet.de> wrote:
> This should be register 66 instead of 62.
> (probably happened by copy&past'ing from the lines below)
>
> Signed-off-by: Daniel Golle <dgolle@allnet.de>

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

John, please apply to the wireless tree for inclusion in 3.7.

>
> ---
>  drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 540c94f..01dc889 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2252,9 +2252,9 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
>          */
>         if (rt2x00_rt(rt2x00dev, RT3352)) {
>                 rt2800_bbp_write(rt2x00dev, 27, 0x0);
> -               rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> +               rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
>                 rt2800_bbp_write(rt2x00dev, 27, 0x20);
> -               rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> +               rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
>         } else {
>                 rt2800_bbp_write(rt2x00dev, 62, 0x37 - rt2x00dev->lna_gain);
>                 rt2800_bbp_write(rt2x00dev, 63, 0x37 - rt2x00dev->lna_gain);
> --
> 1.7.12.2
>



-- 
---
Gertjan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66.
  2012-10-03 23:20 [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66 Daniel Golle
  2012-10-04  9:37 ` Gertjan van Wingerde
@ 2012-10-04 18:58 ` Ivo Van Doorn
  1 sibling, 0 replies; 3+ messages in thread
From: Ivo Van Doorn @ 2012-10-04 18:58 UTC (permalink / raw)
  To: Daniel Golle; +Cc: linux-wireless, linville

On Thu, Oct 4, 2012 at 1:20 AM, Daniel Golle <dgolle@allnet.de> wrote:
> This should be register 66 instead of 62.
> (probably happened by copy&past'ing from the lines below)
>
> Signed-off-by: Daniel Golle <dgolle@allnet.de>

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

>
> ---
>  drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 540c94f..01dc889 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2252,9 +2252,9 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
>          */
>         if (rt2x00_rt(rt2x00dev, RT3352)) {
>                 rt2800_bbp_write(rt2x00dev, 27, 0x0);
> -               rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> +               rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
>                 rt2800_bbp_write(rt2x00dev, 27, 0x20);
> -               rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> +               rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
>         } else {
>                 rt2800_bbp_write(rt2x00dev, 62, 0x37 - rt2x00dev->lna_gain);
>                 rt2800_bbp_write(rt2x00dev, 63, 0x37 - rt2x00dev->lna_gain);
> --
> 1.7.12.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-10-04 18:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-03 23:20 [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register 66 Daniel Golle
2012-10-04  9:37 ` Gertjan van Wingerde
2012-10-04 18:58 ` Ivo Van Doorn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).