Linux wireless drivers development
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
To: Bala Shanmugam <bkamatch@qca.qualcomm.com>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath9k: Set appropriate bit for AR9565 in btc control register
Date: Mon, 15 Oct 2012 12:52:20 +0530	[thread overview]
Message-ID: <20121015072219.GA15591@hemis.qca.qualcomm.com> (raw)
In-Reply-To: <1350282513-3869-1-git-send-email-bkamatch@qca.qualcomm.com>

On Mon, Oct 15, 2012 at 11:58:33AM +0530, Bala Shanmugam wrote:
> Signed-off-by: Bala Shanmugam <bkamatch@qca.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath9k/ar9003_mci.c |   30 ++++++++++++++++++--------
>  1 files changed, 21 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mci.c b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
> index 44c202c..841f2b9 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_mci.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
> @@ -843,15 +843,27 @@ int ar9003_mci_reset(struct ath_hw *ah, bool en_int, bool is_2g,
>  	* MCI mode will be enabled later, right before reset the MCI TX and RX.
>  	*/
>  
> -	regval = SM(1, AR_BTCOEX_CTRL_AR9462_MODE) |
> -		 SM(1, AR_BTCOEX_CTRL_WBTIMER_EN) |
> -		 SM(1, AR_BTCOEX_CTRL_PA_SHARED) |
> -		 SM(1, AR_BTCOEX_CTRL_LNA_SHARED) |
> -		 SM(2, AR_BTCOEX_CTRL_NUM_ANTENNAS) |
> -		 SM(3, AR_BTCOEX_CTRL_RX_CHAIN_MASK) |
> -		 SM(0, AR_BTCOEX_CTRL_1_CHAIN_ACK) |
> -		 SM(0, AR_BTCOEX_CTRL_1_CHAIN_BCN) |
> -		 SM(0, AR_BTCOEX_CTRL_ONE_STEP_LOOK_AHEAD_EN);
> +	if (AR_SREV_9565(ah)) {
> +		regval = SM(1, AR_BTCOEX_CTRL_AR9462_MODE) |
> +			 SM(1, AR_BTCOEX_CTRL_WBTIMER_EN) |
> +			 SM(0, AR_BTCOEX_CTRL_PA_SHARED) |
> +			 SM(0, AR_BTCOEX_CTRL_LNA_SHARED) |
> +			 SM(2, AR_BTCOEX_CTRL_NUM_ANTENNAS) |
> +			 SM(1, AR_BTCOEX_CTRL_RX_CHAIN_MASK) |
> +			 SM(0, AR_BTCOEX_CTRL_1_CHAIN_ACK) |
> +			 SM(0, AR_BTCOEX_CTRL_1_CHAIN_BCN) |
> +			 SM(0, AR_BTCOEX_CTRL_ONE_STEP_LOOK_AHEAD_EN);
NACK. AR9565 uses ANT-1 sharing architecture. These settings are applicable to ANT-2
arch which we don't support. I'll send updated change along with btcoex patch series.

-Rajkumar

      reply	other threads:[~2012-10-15  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15  6:28 [PATCH 1/2] ath9k: Set appropriate bit for AR9565 in btc control register Bala Shanmugam
2012-10-15  7:22 ` Rajkumar Manoharan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121015072219.GA15591@hemis.qca.qualcomm.com \
    --to=rmanohar@qca.qualcomm.com \
    --cc=bkamatch@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox