From: Christian Lamparter <chunkeey@googlemail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, Joshua.Roys@gtri.gatech.edu
Subject: Re: [RFC] rtlwifi: fix in_ep = in_ep_num mishap in _rtl_usb_init_rx
Date: Mon, 15 Oct 2012 12:42:58 +0200 [thread overview]
Message-ID: <201210151242.58431.chunkeey@googlemail.com> (raw)
In-Reply-To: <507B4CE5.2020104@lwfinger.net>
On Monday, October 15, 2012 01:38:13 AM Larry Finger wrote:
> On 10/14/2012 03:13 PM, Christian Lamparter wrote:
> > in_ep and in_ep_num should not be the same as
> > a device can have a different in_ep than "1".
> >
> > Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
> > Larry, do you know of any hardware which has two in endpoints?
>
> The RTL8188CU has the following:
>
> Bus 004 Device 002: ID 0bda:8723 Realtek Semiconductor Corp.
> bEndpointAddress 0x81 EP 1 IN
> bEndpointAddress 0x02 EP 2 OUT
> bEndpointAddress 0x82 EP 2 IN
> bEndpointAddress 0x03 EP 3 OUT
> bEndpointAddress 0x83 EP 3 IN
> bEndpointAddress 0x03 EP 3 OUT
> bEndpointAddress 0x83 EP 3 IN
> bEndpointAddress 0x03 EP 3 OUT
> bEndpointAddress 0x83 EP 3 IN
>
> My SU device has the same layout. It seems that only EP
> 1 is used exclusively for input operations.
It's a bit weird that you have three IN and OUT 0x3 eps. Is this
really true or is this a c&p error and your devices have more
than one interface configuration?
The endpoint configuration for my SU devices (both are the same)
look like this:
Interface Descriptor:
bEndpointAddress 0x83 EP 3 IN Bulk Data 512 bytes
bEndpointAddress 0x04 EP 4 OUT Bulk Data 512 bytes
bEndpointAddress 0x06 EP 6 OUT Bulk Data 512 bytes
bEndpointAddress 0x0d EP 13 OUT Bulk Data 512 bytes
It looks like that we should parse the endpoint descriptor and
get the first endpoint from there.
Regards,
Chr
next prev parent reply other threads:[~2012-10-15 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 20:13 [RFC] rtlwifi: fix in_ep = in_ep_num mishap in _rtl_usb_init_rx Christian Lamparter
2012-10-14 23:38 ` Larry Finger
2012-10-15 10:42 ` Christian Lamparter [this message]
2012-10-15 15:13 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210151242.58431.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=Joshua.Roys@gtri.gatech.edu \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).