From: Antonio Quartulli <ordex@autistici.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCHv3 2/2] mac80211: implement set_mcast_rate() callback
Date: Mon, 29 Oct 2012 10:33:54 +0100 [thread overview]
Message-ID: <20121029093354.GC5944@ritirata.org> (raw)
In-Reply-To: <1351502110.10925.10.camel@jlt4.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On Mon, Oct 29, 2012 at 10:15:10AM +0100, Johannes Berg wrote:
> On Fri, 2012-10-26 at 17:57 +0200, Antonio Quartulli wrote:
> > The callback can be used with vif configured as
> > ADHOC or MESH_POINT only.
>
> You said the same in the cfg80211 patch, so
>
> > +int ieee80211_mcast_rate(struct ieee80211_sub_if_data *sdata,
> > + int rate[IEEE80211_NUM_BANDS])
> > +{
> > + if (sdata->vif.type != NL80211_IFTYPE_ADHOC &&
> > + sdata->vif.type != NL80211_IFTYPE_MESH_POINT)
> > + return -EOPNOTSUPP;
>
> should that check be in cfg80211?
Ok, will change that.
>
> OTOH, it seems it might be valid in AP mode as well?
as we discussed on IRC, the AP has no real mcast_rate parameter since it seems
to be chosen from the basic rates every time. How ever this would be an
interesting feature. Maybe we can add this later after this API change.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-29 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 15:57 [PATCHv3 1/2] nl/cfg80211: add the NL80211_CMD_SET_MCAST_RATE command Antonio Quartulli
2012-10-26 15:57 ` [PATCHv3 2/2] mac80211: implement set_mcast_rate() callback Antonio Quartulli
2012-10-29 9:15 ` Johannes Berg
2012-10-29 9:33 ` Antonio Quartulli [this message]
2012-10-29 9:13 ` [PATCHv3 1/2] nl/cfg80211: add the NL80211_CMD_SET_MCAST_RATE command Johannes Berg
2012-10-29 9:19 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029093354.GC5944@ritirata.org \
--to=ordex@autistici.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).