[PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes

[PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes

[Malcolm Priestley]

After this patch all BYTE/WORD/DWORD types can be replaced with the appropriate u sizes.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
 drivers/staging/vt6656/ttype.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/vt6656/ttype.h b/drivers/staging/vt6656/ttype.h
index 0f70562c..dfbf747 100644
--- a/drivers/staging/vt6656/ttype.h
+++ b/drivers/staging/vt6656/ttype.h
@@ -44,9 +44,9 @@ typedef int             BOOL;
 
 /****** Simple typedefs  ***************************************************/
 
-typedef unsigned char   BYTE;           //  8-bit
-typedef unsigned short  WORD;           // 16-bit
-typedef unsigned long   DWORD;          // 32-bit
+typedef u8 BYTE;
+typedef u16 WORD;
+typedef u32 DWORD;
 
 // QWORD is for those situation that we want
 // an 8-byte-aligned 8 byte long structure
@@ -62,8 +62,8 @@ typedef UQuadWord       QWORD;          // 64-bit
 
 /****** Common pointer types ***********************************************/
 
-typedef unsigned long   ULONG_PTR;      // 32-bit
-typedef unsigned long   DWORD_PTR;      // 32-bit
+typedef u32 ULONG_PTR;
+typedef u32 DWORD_PTR;
 
 // boolean pointer
 
-- 
1.8.0

Re: [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes

[Greg KH]

On Sun, Nov 11, 2012 at 03:41:25PM +0000, Malcolm Priestley wrote:
> 
> After this patch all BYTE/WORD/DWORD types can be replaced with the appropriate u sizes.
> 
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
>  drivers/staging/vt6656/ttype.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/ttype.h b/drivers/staging/vt6656/ttype.h
> index 0f70562c..dfbf747 100644
> --- a/drivers/staging/vt6656/ttype.h
> +++ b/drivers/staging/vt6656/ttype.h
> @@ -44,9 +44,9 @@ typedef int             BOOL;
>  
>  /****** Simple typedefs  ***************************************************/
>  
> -typedef unsigned char   BYTE;           //  8-bit
> -typedef unsigned short  WORD;           // 16-bit
> -typedef unsigned long   DWORD;          // 32-bit
> +typedef u8 BYTE;
> +typedef u16 WORD;
> +typedef u32 DWORD;

That's good, but in the end, we want to get rid of BYTE, WORD, and DWORD
usages in this driver, can you just start replacing them with the proper
types?

thanks,

greg k-h

Re: [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes

[Greg KH]

On Sun, Nov 11, 2012 at 03:41:25PM +0000, Malcolm Priestley wrote:
>  /****** Common pointer types ***********************************************/
>  
> -typedef unsigned long   ULONG_PTR;      // 32-bit
> -typedef unsigned long   DWORD_PTR;      // 32-bit
> +typedef u32 ULONG_PTR;
> +typedef u32 DWORD_PTR;

A pointer does not fit in u32 on all arches, only unsigned long works
here.

thanks,

greg k-h

Re: [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes

[Malcolm Priestley]

On Tue, 2012-11-13 at 12:50 -0800, Greg KH wrote:
> On Sun, Nov 11, 2012 at 03:41:25PM +0000, Malcolm Priestley wrote:
> >  /****** Common pointer types ***********************************************/
> >  
> > -typedef unsigned long   ULONG_PTR;      // 32-bit
> > -typedef unsigned long   DWORD_PTR;      // 32-bit
> > +typedef u32 ULONG_PTR;
> > +typedef u32 DWORD_PTR;
> 
> A pointer does not fit in u32 on all arches, only unsigned long works
> here.
> 
Hi

The naming is misleading, they are not pointers.

I have a upcoming patch to remove them.

Regards


Malcolm

Re: [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes

[Greg KH]

On Tue, Nov 13, 2012 at 09:30:18PM +0000, Malcolm Priestley wrote:
> On Tue, 2012-11-13 at 12:50 -0800, Greg KH wrote:
> > On Sun, Nov 11, 2012 at 03:41:25PM +0000, Malcolm Priestley wrote:
> > >  /****** Common pointer types ***********************************************/
> > >  
> > > -typedef unsigned long   ULONG_PTR;      // 32-bit
> > > -typedef unsigned long   DWORD_PTR;      // 32-bit
> > > +typedef u32 ULONG_PTR;
> > > +typedef u32 DWORD_PTR;
> > 
> > A pointer does not fit in u32 on all arches, only unsigned long works
> > here.
> > 
> Hi
> 
> The naming is misleading, they are not pointers.

Ah, but of course :)

> I have a upcoming patch to remove them.

Ok, that sounds good.

greg k-h